-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Android 11 Conversation features #1809
Conversation
Hello, thx for the contribution! |
@BillCarsonFr No, but it will be possible in the future after this PR. I've begun experimenting with the bubble feature but thought this should go through first. |
Any update on this? |
It looks like sharing shortcuts have been added to Element since I wrote this PR, so that should probably be taken into account before this is merged (though I won't have time to work on it for at least a couple weeks.) |
Android 11 is now properly handled (see #2600 ), this PR should probable be updated after a rebase. |
0eb0c77
to
d63776d
Compare
Sorry this took so long. I've updated this to work better with the API 30 target and stable Conversations API. Here are a few other things I changed:
|
d63776d
to
c9ec8d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rebased these changes on top of develop
and run them locally on my OP6 with Android 11, and very much approve.
Instead of only favorite rooms having shortcuts, all rooms now have shortcuts and they are ranked according to favorite/normal/low-priority status.
Rectangular icons were causing issues with the conversation icon display (probably an Android bug) and shortcut icons were being cropped in unnecessarily.
This prevents shortcuts from momentarily being shown out of order while the shortcut list is in the process of being updated.
18f915c
to
2004d35
Compare
Rebased onto develop and fixed a minor bug with shortcut sorting. I've been using this version of Element for about a month and it's been working great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I think we can merge it (just checking with the team)
3092de8
to
15217d9
Compare
Reporting this on behalf of @bryandesrosiers, after upgrading to 1.2.1, which tagged this PR. 'Chatheads' ala Messenger would be awesome. :- ) |
Odd, I see priority levels but not chat heads (because that's not implemented yet). I've got most of the way to an implementation myself: enough to see the pop-out icon in the notification, but not to actually show the chat when one taps on it. Bit stuck now. Anyone know if there's a specific bug for the remaining pieces that I could tag on to? |
@andrewaylett I had this exact issue a year ago when I was trying my hand at implementing bubbles. No idea why it doesn't work, and I hadn't been able to find any other instances of this problem, though bubbles were a very new feature back then. |
Resolves the first item in #1722
Screenshots:
Pull Request Checklist
Signed-off-by: David Teresi [email protected]