Fix widget permission

Author: p1gp1g

changelog.d/5397.bugfix

@@ -0,0 +1 @@
+Fix widget permission

vector/src/main/java/im/vector/app/features/widgets/WidgetFragment.kt

@@ -86,8 +86,10 @@ class WidgetFragment @Inject constructor(
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         views.widgetWebView.setupForWidget(requireActivity(), checkWebViewPermissionsUseCase, this)
-        if (fragmentArgs.kind.isAdmin()) {
-            viewModel.getPostAPIMediator().setWebView(views.widgetWebView)
+        withState(viewModel) { state ->
+            if (state.status == WidgetStatus.WIDGET_ALLOWED) {
+                viewModel.getPostAPIMediator().setWebView(views.widgetWebView)
+            }
         }
         viewModel.observeViewEvents {
             Timber.v("Observed view events: $it")
@@ -118,8 +120,10 @@ class WidgetFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        if (fragmentArgs.kind.isAdmin()) {
-            viewModel.getPostAPIMediator().clearWebView()
+        withState(viewModel) { state ->
+            if (state.status == WidgetStatus.WIDGET_ALLOWED) {
+                viewModel.getPostAPIMediator().clearWebView()
+            }
         }
         views.widgetWebView.clearAfterWidget()
         super.onDestroyView()

vector/src/main/java/im/vector/app/features/widgets/WidgetViewModel.kt

@@ -77,12 +77,12 @@ class WidgetViewModel @AssistedInject constructor(
 
     init {
         integrationManagerService.addListener(this)
-        if (initialState.widgetKind.isAdmin()) {
-            widgetPostAPIHandler = widgetPostAPIHandlerFactory.create(initialState.roomId).apply {
-                navigationCallback = this@WidgetViewModel
-            }
-            postAPIMediator.setHandler(widgetPostAPIHandler)
+        // WidgetStatus is still unknown
+        // Nevertheless, we can create the Handler without using it later
+        widgetPostAPIHandler = widgetPostAPIHandlerFactory.create(initialState.roomId).apply {
+            navigationCallback = this@WidgetViewModel
         }
+        postAPIMediator.setHandler(widgetPostAPIHandler)
         if (!integrationManagerService.isIntegrationEnabled()) {
             _viewEvents.post(WidgetViewEvents.Close(null))
         }
@@ -248,8 +248,10 @@ class WidgetViewModel @AssistedInject constructor(
     }
 
     private fun handleWebViewLoadingSuccess(action: WidgetAction.OnWebViewLoadingSuccess) {
-        if (initialState.widgetKind.isAdmin()) {
-            postAPIMediator.injectAPI()
+        withState { state ->
+            if (state.status == WidgetStatus.WIDGET_ALLOWED) {
+                postAPIMediator.injectAPI()
+            }
         }
         setState { copy(webviewLoadedUrl = Success(action.url)) }
     }