Merge pull request #4129 from vector-im/feature/adm/sync-read-notifications

Fixing notifications not being dismissed when read from other devices

Author: bmarty

changelog.d/3347.bugfix

@@ -0,0 +1 @@
+Fixes notifications not dismissing when reading messages on other devices

matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/query/ReadQueries.kt

@@ -39,26 +39,43 @@ internal fun isEventRead(realmConfiguration: RealmConfiguration,
         val liveChunk = ChunkEntity.findLastForwardChunkOfRoom(realm, roomId) ?: return@use
         val eventToCheck = liveChunk.timelineEvents.find(eventId)
         isEventRead = when {
-            eventToCheck == null                -> {
-                // This can happen in case of fast lane Event
-                false
-            }
+            eventToCheck == null                -> hasReadMissingEvent(
+                    realm = realm,
+                    latestChunkEntity = liveChunk,
+                    roomId = roomId,
+                    userId = userId,
+                    eventId = eventId
+            )
             eventToCheck.root?.sender == userId -> true
             else                                -> {
-                val readReceipt = ReadReceiptEntity.where(realm, roomId, userId).findFirst()
-                        ?: return@use
-                val readReceiptIndex = liveChunk.timelineEvents.find(readReceipt.eventId)?.displayIndex
-                        ?: Int.MIN_VALUE
-                val eventToCheckIndex = eventToCheck.displayIndex
-
-                eventToCheckIndex <= readReceiptIndex
+                val readReceipt = ReadReceiptEntity.where(realm, roomId, userId).findFirst() ?: return@use
+                val readReceiptIndex = liveChunk.timelineEvents.find(readReceipt.eventId)?.displayIndex ?: Int.MIN_VALUE
+                eventToCheck.displayIndex <= readReceiptIndex
             }
         }
     }
 
     return isEventRead
 }
 
+/**
+ * Missing events can be caused by the latest timeline chunk no longer contain an older event or
+ * by fast lane eagerly displaying events before the database has finished updating
+ */
+private fun hasReadMissingEvent(realm: Realm, latestChunkEntity: ChunkEntity, roomId: String, userId: String, eventId: String): Boolean {
+    return realm.doesEventExistInChunkHistory(eventId) && realm.hasReadReceiptInLatestChunk(latestChunkEntity, roomId, userId)
+}
+
+private fun Realm.doesEventExistInChunkHistory(eventId: String): Boolean {
+    return ChunkEntity.findIncludingEvent(this, eventId) != null
+}
+
+private fun Realm.hasReadReceiptInLatestChunk(latestChunkEntity: ChunkEntity, roomId: String, userId: String): Boolean {
+    return ReadReceiptEntity.where(this, roomId = roomId, userId = userId).findFirst()?.let {
+        latestChunkEntity.timelineEvents.find(it.eventId)
+    } != null
+}
+
 internal fun isReadMarkerMoreRecent(realmConfiguration: RealmConfiguration,
                                     roomId: String?,
                                     eventId: String?): Boolean {