Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dendrite includes an unspecced "room_id" field in /hierarchy response #2588

Closed
matrixbot opened this issue Nov 1, 2024 · 1 comment
Closed

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @clokep at matrix-org/dendrite#2588.

MSC2946 dropped a room_id field from each entry in children_state, since it is redundant. This change was not properly reflected in Synapse or Dendrite.

I'm updating complement (matrix-org/complement#422) to no longer depend on this field, but Dendrite still returns it. I'm unsure if it is as simple as removing this line from gomatrixserverlib, but it seems to be an initial spot to check at least:

https://github.com/matrix-org/gomatrixserverlib/blob/a75fa15a03a00236a26744e0fc6cea20b4eb69ee/federationtypes.go#L799

Cross-linking the Synapse issue: matrix-org/synapse#10946.

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @clokep at matrix-org/dendrite#2588 (comment).

Thanks for taking care of this quickly! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant