This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Dont merge now, I will add some test cases. |
This was referenced Jan 23, 2015
These are excellent changes. Really looking forward to having this mainlined. 😄 |
|
||
|
||
def _cast_string(v): | ||
assert isinstance(v, str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should test for basestring
on Python 2.6/2.7, else it will fail on unicode strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thriftpy always read thrift files as strings, not unicode strings.
Can be merged now. Better to upgrade thriftpy after merge this pr. |
Excellent! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes: (All changes are parser part.)
include_dirs
toinclude_dir
, parser will try to find all child thrifts files inside this directory during a parsing progress. (Non-Backward-Compatible)const i32 i = 1.5
will be rejected now.struct Person {1: required string name}; const Person tom = {}
will be rejected now.load
, we can enable cache on parsing (default enabled)a->b->c->a
will be rejected.The changes above contains 1 non-backward-compat change.
The parser makes thriftpy behaves closer to apache thrift.
@maralla will merge this pull request.