This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Add support for includes & service extends #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikekap
commented
Sep 10, 2014
mikekap
commented
- Add support for includes. load() now takes an optional include_dirs argument that specifies relative paths.
- Add support for service "extends".
added 3 commits
September 9, 2014 20:04
- Add support for includes. load() now takes an optional include_dirs argument that specifies relative paths. - Add support for service "extends".
|
Really a nice pr @lxyu |
added 2 commits
September 9, 2014 21:48
…ng from enums. This makes it a lot easier to build reflection-like tools, e.g. converting JSON to Thrift that might use strings for enums.
lxyu
added a commit
that referenced
this pull request
Sep 10, 2014
Add support for includes & service extends
|
For simple thrift files this isn't an issue. But if you're importing a thrift file from a directory that's not the "thrift root", you'll run into problems with includes, e.g. given thrift/scribe/if/scribe.thrift (has include "fb303/if/fb303.thrift") In this setup, you can't use thriftpy to import thrift/scribe/if/scribe.thrift without doing some chdir magic. In general, I think this mirrors the -I thrift compiler option, which is good for compatibility. |
|
👍 @mikekap thanks for those awesome PRs, I have just released v0.1.11 with all these changes to pypi, you may use it from that now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.