This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Tell c_read_binary that it's decoding characters #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These type and size hints let cython optimize the string decoding operation to a pair of `__Pyx_PyObject_AsString` / `__Pyx_decode_c_string()` calls. This is a lot more efficient than the previous code generation which invoked the "encode" method on the abstract "py_data" object. The performance improvement here varies based on how much string data exists in the input buffer, but the benchmark suite shows a 40%+ speed improvement with this change.
|
👍 Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These type and size hints let cython optimize the string decoding operation
to a pair of
__Pyx_PyObject_AsString/__Pyx_decode_c_string()calls. Thisis a lot more efficient than the previous code generation which invoked the
"encode" method on the abstract "py_data" object.
The performance improvement here varies based on how much string data exists
in the input buffer, but the benchmark suite shows a 40%+ speed improvement
with this change.