Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

support TCompactProtocol #159

Closed
wants to merge 11 commits into from
Closed

support TCompactProtocol #159

wants to merge 11 commits into from

Conversation

caorong
Copy link
Contributor

@caorong caorong commented Oct 7, 2015

No description provided.

@lxyu
Copy link
Contributor

lxyu commented Oct 10, 2015

It seems to be directly moved from the upstream Apache, which means many code can be simplified in a more pythonic way, including logic, naming and style..

@caorong
Copy link
Contributor Author

caorong commented Oct 10, 2015

you are right, I will take some time to fix it..

@caorong
Copy link
Contributor Author

caorong commented Oct 13, 2015

@lxyu plz merge, we need this feature recently.

@lxyu
Copy link
Contributor

lxyu commented Oct 13, 2015

@caorong sorry I may not able to merge this in a short time, since support a protocol requires more time to do improvements and testing.

I'd recommend you to put this protocol implementation in client side code base and use it with thriftpy or do some monkey_patch magic, if you need this feature recently.

@caorong
Copy link
Contributor Author

caorong commented Oct 13, 2015

@lxyu 👍

@mariusvniekerk
Copy link

Anything that I can help with to get this merged?

@lxyu
Copy link
Contributor

lxyu commented Jan 22, 2016

Yah just noticed the PR updated. I'll put it in the review process, hopefully get it merged in next week.

lxyu added a commit that referenced this pull request Feb 16, 2016
@lxyu
Copy link
Contributor

lxyu commented Feb 16, 2016

Merged in 391921b

Thanks for contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants