Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrected the verification of Mono and Wine installation status #488

Merged

Conversation

BitYoungjae
Copy link
Contributor

The old code wrongly checked if Mono and Wine were installed. It looked like this:

export async function createWindowsInstaller(options: SquirrelWindowsOptions): Promise<void> {
let useMono = false;
const monoExe = 'mono';
const wineExe = process.arch === 'x64' ? 'wine64' : 'wine';
if (process.platform !== 'win32') {
useMono = true;
if (!wineExe || !monoExe) {
throw new Error('You must install both Mono and Wine on non-Windows');
}
log(`Using Mono: '${monoExe}'`);
log(`Using Wine: '${wineExe}'`);
}

The part (!wineExe || !monoExe) didn't work right because wineExe and monoExe were just text, not real checks.

Now, the code really checks if Wine and Mono are there. This fix makes sure the setup works right and checks everything needed.

@BitYoungjae BitYoungjae requested a review from a team as a code owner October 23, 2023 06:33
src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL @electron/wg-ecosystem

@BlackHole1 BlackHole1 merged commit 2fb8e5c into electron:main Oct 24, 2023
3 checks passed
@continuous-auth
Copy link

🎉 This PR is included in version 5.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants