Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility audit helper #79

Merged
merged 15 commits into from
Jul 6, 2016
Merged

Add accessibility audit helper #79

merged 15 commits into from
Jul 6, 2016

Conversation

kevinsawicki
Copy link
Collaborator

Adds support for running an accessibility audit using https://github.com/GoogleChrome/accessibility-developer-tools

New API is app.client.auditAccessibility() and it resolves to an audit object with details about any failures.

/cc @jlord @zeke

center: true,
width: 800,
height: 400,
minHeight: 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are minHeight and minWidth needed for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied another fixtures folder that had these set, they aren't explicitly needed by any of the new accessibility specs.

@zeke
Copy link
Member

zeke commented Jul 5, 2016

I wonder if you could just npm install accessibility-developer-tools instead of manually copying the bundled source...

@kevinsawicki
Copy link
Collaborator Author

I wonder if you could just npm install accessibility-developer-tools instead of manually copying the bundled source...

You can't, it isn't require-able.

@zeke
Copy link
Member

zeke commented Jul 6, 2016

it isn't require-able.

I took at stab at making it require-able last night. Got close but still a few hiccups.

Obviously this is just a nice-to-have. In the meantime, I say :shipit:

@kevinsawicki
Copy link
Collaborator Author

I took at stab at making it require-able last night. Got close but still a few hiccups.

Yeah, it would be great to switch it to an npm dependency eventually if upstream addresses this issue.

@dylanb
Copy link

dylanb commented Jul 11, 2016

If you want an accessibility module that supports require (UMD) and has a bigger and more robust set of rules, take a look at axe-core https://www.npmjs.com/package/axe-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants