-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility audit helper #79
Conversation
center: true, | ||
width: 800, | ||
height: 400, | ||
minHeight: 100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are minHeight
and minWidth
needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied another fixtures folder that had these set, they aren't explicitly needed by any of the new accessibility specs.
33d1b13
to
0536a2d
Compare
I wonder if you could just |
You can't, it isn't require-able. |
I took at stab at making it require-able last night. Got close but still a few hiccups. Obviously this is just a nice-to-have. In the meantime, I say |
Yeah, it would be great to switch it to an npm dependency eventually if upstream addresses this issue. |
If you want an accessibility module that supports require (UMD) and has a bigger and more robust set of rules, take a look at axe-core https://www.npmjs.com/package/axe-core |
Adds support for running an accessibility audit using https://github.com/GoogleChrome/accessibility-developer-tools
New API is
app.client.auditAccessibility()
and it resolves to anaudit
object with details about any failures./cc @jlord @zeke