Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm >= 5's prune reinstalls ignored node modules #797

Closed
jean-emmanuel opened this issue Feb 2, 2018 · 5 comments
Closed

npm >= 5's prune reinstalls ignored node modules #797

jean-emmanuel opened this issue Feb 2, 2018 · 5 comments
Labels

Comments

@jean-emmanuel
Copy link

Since version 5, npm prune reinstalls all missing dependencies, this breaks electron-packager's --ignore option when --no-prune is not set.

@welcome
Copy link

welcome bot commented Feb 2, 2018

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@malept malept added the bug 🐛 label Feb 2, 2018
@malept
Copy link
Member

malept commented Feb 2, 2018

~~I assume you mean when --prune is set, because npm prune isn't run when --no-prune is set.~ Never mind, saying "when --no-prune is not set" confused me, because of double negatives.

Sigh. This is why I'm dropping all support for npm and yarn when pruning.

@jean-emmanuel
Copy link
Author

jean-emmanuel commented Feb 2, 2018

Indeed !

Edit: haha I think I got confused too !

@malept malept changed the title npm prune reinstalls ingnored node modules npm >= 5's prune reinstalls ingnored node modules Feb 2, 2018
@malept malept changed the title npm >= 5's prune reinstalls ingnored node modules npm >= 5's prune reinstalls ignored node modules Feb 2, 2018
@malept
Copy link
Member

malept commented Feb 2, 2018

The current workaround is to set --no-package-manager.

@jean-emmanuel
Copy link
Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants