-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not copy devDependencies into the packaged app, prior to the prune step #198
Comments
Thanks for the feature request, this is a duplicate of #35 (making |
@malept, I don't think these are the same issues. The problem that I have is that electron-packager looks at all the modules that are in my devDependencies which take a lot of time given their size. Adding |
(I edited the issues so that the comment from #35 is here, as that's where it's relevant.)
Fair enough. I can't think of a good reason to not ignore |
See also: #235 |
I saw a really poor implementation of this the other day. I believe the correct way to do it is something like this (pseudocode): let package = require('./package.json');
// calculateDependencyTree returns a flat list of versioned dependencies, including
// sub-dependencies, for a given list of packages.
dependenciesToExclude() {
let dependencies = calculateDependencyTree(package.dependencies);
let devDependencies = calculateDependencyTree(package.devDependencies);
return devDependencies - dependencies;
} Ideally, this implementation does not depend on |
This should be possible soon MarshallOfSound/pruner#1 |
My dev dependencies are quite large (
babel
alone is over 300MB). Theelectron-packager
analyses all those files which causes the build time to take a long time. I ended up explicitly ignoring all node modules that I want:Why not make it the default behaviour of
electron-package
to ignore dev dependencies?The text was updated successfully, but these errors were encountered: