Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublisherERS add support for Apple Silicon #3225

Closed
3 tasks done
andrii-kryvoviaz opened this issue Apr 29, 2023 · 2 comments
Closed
3 tasks done

PublisherERS add support for Apple Silicon #3225

andrii-kryvoviaz opened this issue Apr 29, 2023 · 2 comments

Comments

@andrii-kryvoviaz
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.1.1

Electron version

v24.1.2

Operating system

macOS 13.3.1

Last known working Electron Forge version

No response

Expected behavior

Publish to appropriate platform and arch.

Actual behavior

Always publishes a new version under osx_64.

Steps to reproduce

Run publish script from an Apple Silicon Mac.

Additional information

It's an easy fix, just change:

case 'darwin':
      return 'osx_x64';

to

case 'darwin':
      return arch === 'arm64' ? 'osx_arm64' : 'osx_x64';
@liyaquath-code
Copy link

Even I'm facing this issue. I was about to create an issue for this... luckily it already exists. Do we have any plan when we this will be implemented?

@erickzhao
Copy link
Member

Closed in #3270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants