Skip to content

Commit dc75e94

Browse files
fcastilloecmalept
authored andcommitted
Always add revision/release to the RPM filename (#114)
* Use the Release (revision) number on the filename * Fix tests to account to Release(revision)
1 parent e0da5af commit dc75e94

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/installer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const util = require('./util')
1515
const defaultLogger = debug('electron-installer-redhat')
1616

1717
const defaultRename = function (dest, src) {
18-
return path.join(dest, '<%= name %>-<%= version %>.<%= arch %>.rpm')
18+
return path.join(dest, '<%= name %>-<%= version %>-<%= revision %>.<%= arch %>.rpm')
1919
}
2020

2121
class RedhatInstaller extends common.ElectronInstaller {

test/cli.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('cli', function () {
2929

3030
runCLI({ src: 'test/fixtures/app-with-asar/', dest: outputDir, arch: 'x86' })
3131

32-
it('generates a `.rpm` package', () => access(path.join(outputDir, 'footest-0.0.1.x86.rpm')))
32+
it('generates a `.rpm` package', () => access(path.join(outputDir, 'footest-0.0.1-1.x86.rpm')))
3333

3434
cleanupOutputDir(outputDir)
3535
})
@@ -39,7 +39,7 @@ describe('cli', function () {
3939

4040
runCLI({ src: 'test/fixtures/app-without-asar/', dest: outputDir, arch: 'x86_64' })
4141

42-
it('generates a `.rpm` package', () => access(path.join(outputDir, 'bartest-0.0.1.x86_64.rpm')))
42+
it('generates a `.rpm` package', () => access(path.join(outputDir, 'bartest-0.0.1-1.x86_64.rpm')))
4343

4444
after(() => fs.remove(outputDir))
4545
})

0 commit comments

Comments
 (0)