New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when HMR fails, it should fallback to page reload #1281

Closed

ZibanPirate wants to merge 1 commit into electron:master from ZibanPirate:patch-1

ZibanPirate commented Nov 17, 2019

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project follows, as appropriate.
The changes are appropriately documented (if applicable).
The changes have sufficient test coverage (if applicable).
The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

when HMR fails (in case of React for example), it should do a page reload.

see #1247 and #1164


          when HMR fails, it should fallback to page reload

5c8392f

when HMR fails (in case of React for example), it should do a page reload.

VerteDinde closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet