Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use disableDifferentialDownload flag in the AppImageBuilder #8695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peter-sanderson
Copy link

@peter-sanderson peter-sanderson commented Nov 19, 2024

Hi, this is my first contribution here so please LMK if I did something wrong.

  • I have a quite trouble running the tests. It produces a lot of errors that seem unrelated.
  • I was able to run pnpm compile && TEST_FILES=linuxUpdaterTest.ts pnpm ci:test and it passed
  • It also seems there is missing a test for AppImage (test AppImage download) is commented and not working

@peter-sanderson peter-sanderson force-pushed the disableDifferentialDownload-on-linux branch from 4704d7f to a65b446 Compare November 21, 2024 09:24
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 03652f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta
Copy link
Collaborator

Quick update: PR looks good! Just to double-check, did you test the full update process locally with a packaged app on your dev machine? Or was it only the unit tests? I need to double check if there's a differential update unit test for linux

@peter-sanderson
Copy link
Author

peter-sanderson commented Nov 27, 2024

@mmaietta Hi, what I did was that I have build the app and rsynced the out directory into node_modules in my app. That worked in a sense, that it processed the update by not using the differential flow.

About tests, as mentioned, I was not able to run them all. So I run selectively the linuxUpdaterTest.ts. That passed but it does not test the AppImage.

I also found and run differentialUpdateTest.ts it passes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants