feat(appx): attempt to use identityName for manifest name #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very useful to set a custom `identityName` when the name of the app in package.json contains hyphens (which are not permitted in `appxmanifest.yml`). Even if you set a non-hyphenated name as `identityName`, electron-builder will still use the package.json's `name` property for the `name` appxmanifest.yml value. Thus, we attempt to re-use `identityName` for that case as well. Signed-off-by: Juan Cruz Viotti <[email protected]>
|
@jviotti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @black-snow, @surajreddy and @MariaDima to be potential reviewers. |
|
I see that you are right. Thanks. |
|
Released as 19.22.1 Decided to not release as major release because appx is not default target and identity name is not required option. |
|
Sounds great to me, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very useful to set a custom
identityNamewhen the name of theapp in package.json contains hyphens (which are not permitted in
appxmanifest.yml).Even if you set a non-hyphenated name as
identityName,electron-builder will still use the package.json's
nameproperty forthe
nameappxmanifest.yml value.Thus, we attempt to re-use
identityNamefor that case as well.Signed-off-by: Juan Cruz Viotti [email protected]