fix: pnpm collection of optional dependencies

node-module-collector should not expect optional dependencies to be
present on disk. If `require('dep/package.json')` throws for optional
dependency - it is completley safe to continue as if it was never
installed.

Author: indutny-signal

.changeset/witty-queens-trade.md

@@ -0,0 +1,5 @@
+---
+"app-builder-lib": major
+---
+
+fix: pnpm collection of optional dependencies

CHANGELOG.md

@@ -1,3 +1,13 @@
+# [](https://github.com/electron-userland/electron-builder/compare/v26.0.11...v) (2025-03-13)
+
+
+### Bug Fixes
+
+* pnpm collection of optional dependencies ([96abe76](https://github.com/electron-userland/electron-builder/commit/96abe76d8c4a033276f96ad92db7b2a0e28530aa))
+* support `mas` packages for flipping fuses ([#8947](https://github.com/electron-userland/electron-builder/issues/8947)) ([7ba4fea](https://github.com/electron-userland/electron-builder/commit/7ba4fea95825650f02749949632b351c75d3019a))
+
+
+
 # [](https://github.com/electron-userland/electron-builder/compare/v26.0.10...v) (2025-03-09)
 
 

packages/app-builder-lib/src/node-module-collector/pnpmNodeModulesCollector.ts

@@ -39,17 +39,30 @@ export class PnpmNodeModulesCollector extends NodeModulesCollector<PnpmDependenc
   extractProductionDependencyTree(tree: PnpmDependency): DependencyTree {
     const p = path.normalize(this.resolvePath(tree.path))
     const packageJson: Dependency<string, string> = require(path.join(p, "package.json"))
-    const prodDependencies = { ...(packageJson.dependencies || {}), ...(packageJson.optionalDependencies || {}) }
 
     const deps = { ...(tree.dependencies || {}), ...(tree.optionalDependencies || {}) }
     const dependencies = Object.entries(deps).reduce<DependencyTree["dependencies"]>((acc, curr) => {
       const [packageName, dependency] = curr
-      if (!prodDependencies[packageName]) {
+
+      let isOptional: boolean
+      if (packageJson.dependencies?.[packageName]) {
+        isOptional = false
+      } else if (packageJson.optionalDependencies?.[packageName]) {
+        isOptional = true
+      } else {
         return acc
       }
-      return {
-        ...acc,
-        [packageName]: this.extractProductionDependencyTree(dependency),
+
+      try {
+        return {
+          ...acc,
+          [packageName]: this.extractProductionDependencyTree(dependency),
+        }
+      } catch (error) {
+        if (isOptional) {
+          return acc
+        }
+        throw error
       }
     }, {})