From 0be983e52c9477693e226cfb2354fa9a2adba7ae Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Sun, 13 Aug 2017 03:05:11 -0400 Subject: [PATCH] feat(appx): use identityName for app name (#1941) BREAKING CHANGE: if identityName is specified in your config and differs from your app name, appx id will be changed to identify name. It is very useful to set a custom `identityName` when the name of the app in package.json contains hyphens (which are not permitted in `appxmanifest.yml`). Even if you set a non-hyphenated name as `identityName`, electron-builder will still use the package.json's `name` property for the `name` appxmanifest.yml value. Thus, we attempt to re-use `identityName` for that case as well. Signed-off-by: Juan Cruz Viotti --- packages/electron-builder/src/targets/appx.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/electron-builder/src/targets/appx.ts b/packages/electron-builder/src/targets/appx.ts index 574df1d9b0e..6bf9956f60b 100644 --- a/packages/electron-builder/src/targets/appx.ts +++ b/packages/electron-builder/src/targets/appx.ts @@ -125,7 +125,7 @@ export default class AppXTarget extends Target { return appInfo.versionInWeirdWindowsForm case "name": - return appInfo.name + return options.identityName || appInfo.name case "identityName": return options.identityName || appInfo.name