Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an lsn header to the change messages #2214

Open
samwillis opened this issue Dec 30, 2024 · 2 comments
Open

Add an lsn header to the change messages #2214

samwillis opened this issue Dec 30, 2024 · 2 comments

Comments

@samwillis
Copy link
Contributor

samwillis commented Dec 30, 2024

The LSN is very useful for being able to "align" streams with each other. Currently the LSN is a part of the offset, but this is likely to change in the future. It would be useful if the LSN was added as a header to each change message.

@KyleAMathews
Copy link
Contributor

And we're going to drop the offset from messages as well?

@samwillis
Copy link
Contributor Author

@KyleAMathews

@icehaunter and @balegas have implied that the offset format will change and become storage dependent. I suspect a byte offset in our storage logs, if that happens we have a chicken and egg situation where the offset is a variable number of bytes in the JSON in the log, but is referencing its own offset in that log.... so I suspect we may want to drop it if thats the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants