Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #581

Open
ErikPelli opened this issue Dec 20, 2024 · 3 comments
Open

Refactor tests #581

ErikPelli opened this issue Dec 20, 2024 · 3 comments
Assignees
@CameronBadman
Labels
good first issue

Comments

@ErikPelli
Copy link
Collaborator

ErikPelli commented Dec 20, 2024 •
edited
Loading

Current tests are legacy and really old, no one cared much about them.
Failing tests are not reporting the errors to the pipeline result, the whole pipeline should fail, and not report a success.

  1. Try to fix the commented tests (with //), and re-enable them
  2. Rewrite all the tests using testify library (currently used for http1parser_test package)
  3. Refactor the code of the tests to make them more readable
@CameronBadman
Copy link
Contributor

@ErikPelli can you assign me this please?

@ErikPelli
Copy link
Collaborator Author

sure

@ErikPelli
Copy link
Collaborator Author

ErikPelli commented Jan 10, 2025 •
edited
Loading

For the shared proxy functions, like createProxy and all the others that are duplicated, you have to create another package that is imported by all the other tests.
Alright @CameronBadman ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CameronBadman CameronBadman

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErikPelli @CameronBadman