/Cluster/Nodes endpoints should extend a base, abstract class

All endpoints use a NodeID, extending from an abstract class minimizes code
copy/paste

src/Elasticsearch/Endpoints/Cluster/Nodes/AbstractNodesEndpoint.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ * User: zach
+ * Date: 1/23/14
+ * Time: 6:03 PM
+ */
+
+namespace Elasticsearch\Endpoints\Cluster\Nodes;
+
+
+use Elasticsearch\Common\Exceptions\InvalidArgumentException;
+use Elasticsearch\Endpoints\AbstractEndpoint;
+
+abstract class AbstractNodesEndpoint extends AbstractEndpoint
+{
+    /** @var  string  A comma-separated list of node IDs or names to limit the returned information; use `_local` to return information from the node you&#039;re connecting to, leave empty to get information from all nodes */
+    protected $nodeID;
+
+
+    /**
+     * @param $nodeID
+     *
+     * @throws \Elasticsearch\Common\Exceptions\InvalidArgumentException
+     *
+     * @return $this
+     */
+    public function setNodeID($nodeID)
+    {
+        if (isset($nodeID) !== true) {
+            return $this;
+        }
+
+        if (!(is_array($nodeID) === true || is_string($nodeID) === true)) {
+            throw new InvalidArgumentException("invalid node_id");
+        }
+
+        if (is_array($nodeID) === true) {
+            $nodeID = implode(',', $nodeID);
+        }
+
+        $this->nodeID = $nodeID;
+        return $this;
+    }
+}

src/Elasticsearch/Endpoints/Cluster/Nodes/HotThreads.php

@@ -20,34 +20,15 @@
  * @link     http://elasticsearch.org
  */
 
-class HotThreads extends AbstractEndpoint
+class HotThreads extends AbstractNodesEndpoint
 {
-    // A comma-separated list of node IDs or names to limit the returned information; use `_local` to return information from the node you're connecting to, leave empty to get information from all nodes
-    private $node_id;
-
-
-    /**
-     * @param $node_id
-     *
-     * @return $this
-     */
-    public function setNodeID($node_id)
-    {
-        if (isset($node_id) !== true) {
-            return $this;
-        }
-
-        $this->node_id = $node_id;
-        return $this;
-    }
-
 
     /**
      * @return string
      */
     protected function getURI()
     {
-        $node_id = $this->node_id;
+        $node_id = $this->nodeID;
         $uri   = "/_cluster/nodes/hotthreads";
 
         if (isset($node_id) === true) {

src/Elasticsearch/Endpoints/Cluster/Nodes/Info.php

@@ -20,32 +20,12 @@
  * @link     http://elasticsearch.org
  */
 
-class Info extends AbstractEndpoint
+class Info extends AbstractNodesEndpoint
 {
-    // A comma-separated list of node IDs or names to limit the returned information; use `_local` to return information from the node you're connecting to, leave empty to get information from all nodes
-    private $node_id;
-
 
     // A comma-separated list of metrics you wish returned. Leave empty to return all.
     private $metric;
 
-
-    /**
-     * @param $node_id
-     *
-     * @return $this
-     */
-    public function setNodeID($node_id)
-    {
-        if (isset($node_id) !== true) {
-            return $this;
-        }
-
-        $this->node_id = $node_id;
-        return $this;
-    }
-
-
     /**
      * @param $metric
      *
@@ -71,7 +51,7 @@ public function setMetric($metric)
      */
     protected function getURI()
     {
-        $node_id = $this->node_id;
+        $node_id = $this->nodeID;
         $metric = $this->metric;
         $uri   = "/_nodes";
 

src/Elasticsearch/Endpoints/Cluster/Nodes/Shutdown.php

@@ -20,34 +20,15 @@
  * @link     http://elasticsearch.org
  */
 
-class Shutdown extends AbstractEndpoint
+class Shutdown extends AbstractNodesEndpoint
 {
-    // A comma-separated list of node IDs or names to perform the operation on; use `_local` to perform the operation on the node you're connected to, leave empty to perform the operation on all nodes
-    private $node_id;
-
-
-    /**
-     * @param $node_id
-     *
-     * @return $this
-     */
-    public function setNodeID($node_id)
-    {
-        if (isset($node_id) !== true) {
-            return $this;
-        }
-
-        $this->node_id = $node_id;
-        return $this;
-    }
-
 
     /**
      * @return string
      */
     protected function getURI()
     {
-        $node_id = $this->node_id;
+        $node_id = $this->nodeID;
         $uri   = "/_shutdown";
 
         if (isset($node_id) === true) {

src/Elasticsearch/Endpoints/Cluster/Nodes/Stats.php

@@ -20,7 +20,7 @@
  * @link     http://elasticsearch.org
  */
 
-class Stats extends AbstractEndpoint
+class Stats extends AbstractNodesEndpoint
 {
     // Limit the information returned to the specified metrics
     private $metric;
@@ -29,11 +29,6 @@ class Stats extends AbstractEndpoint
     // Limit the information returned for `indices` metric to the specific index metrics. Isn't used if `indices` (or `all`) metric isn't specified.
     private $indexMetric;
 
-
-    // A comma-separated list of node IDs or names to limit the returned information; use `_local` to return information from the node you're connecting to, leave empty to get information from all nodes
-    private $node_id;
-
-
     /**
      * @param $metric
      *
@@ -74,30 +69,14 @@ public function setIndexMetric($indexMetric)
     }
 
 
-    /**
-     * @param $node_id
-     *
-     * @return $this
-     */
-    public function setNodeID($node_id)
-    {
-        if (isset($node_id) !== true) {
-            return $this;
-        }
-
-        $this->node_id = $node_id;
-        return $this;
-    }
-
-
     /**
      * @return string
      */
     protected function getURI()
     {
         $metric = $this->metric;
         $index_metric = $this->indexMetric;
-        $node_id = $this->node_id;
+        $node_id = $this->nodeID;
         $uri   = "/_nodes/stats";
 
         if (isset($node_id) === true && isset($metric) === true && isset($index_metric) === true) {