Yaml tests have curious definitions for 'truthy' and 'falsey

Set an explicit list so that there are no confusions
elastic · Jan 20, 2014 · 67b29d3 · 67b29d3
1 parent 6738578
commit 67b29d3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tests/Elasticsearch/Tests/YamlRunnerTest.php b/tests/Elasticsearch/Tests/YamlRunnerTest.php
@@ -114,7 +114,7 @@ private function assertTruthy($value)
     {
         echo "\n         |assertTruthy: ".json_encode($value)."\n";
         ob_flush();
-        if (!$value) {
+        if (isset($value) === false || $value === 0 || $value === false || $value === null || $value === '') {
             $this->fail("Value is not truthy: ".print_r($value, true));
         }
     }
@@ -123,7 +123,7 @@ private function assertFalsey($value)
     {
         echo "\n         |assertFalsey: ".json_encode($value)."\n";
         ob_flush();
-        if ($value) {
+        if (!(isset($value) === false || $value === 0 || $value === false || $value === null || $value === '')) {
             $this->fail("Value is not falsey: ".print_r($value, true));
         }
     }