Randomise the test policy names to support reruns

Author: tobio

internal/kibana/synthetics/private_location/acc_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/elastic/terraform-provider-elasticstack/internal/acctest"
 	"github.com/elastic/terraform-provider-elasticstack/internal/versionutils"
 	"github.com/hashicorp/go-version"
+	sdkacctest "github.com/hashicorp/terraform-plugin-testing/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
@@ -29,14 +30,15 @@ var (
 
 func TestSyntheticPrivateLocationResource(t *testing.T) {
 	resourceId := "elasticstack_kibana_synthetics_private_location.test"
+	randomSuffix := sdkacctest.RandStringFromCharSet(4, sdkacctest.CharSetAlphaNum)
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { acctest.PreCheck(t) },
 		ProtoV6ProviderFactories: acctest.Providers,
 		Steps: []resource.TestStep{
 			// Create and Read testing
 			{
 				SkipFunc: versionutils.CheckIfVersionIsUnsupported(minKibanaPrivateLocationAPIVersion),
-				Config: testConfig("testacc", "test_policy") + `
+				Config: testConfig("testacc", "test_policy", randomSuffix) + `
 resource "elasticstack_kibana_synthetics_private_location" "test" {
 	label = "pl-test-label"
 	agent_policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
@@ -63,7 +65,7 @@ resource "elasticstack_kibana_synthetics_private_location" "test" {
 				ResourceName:      resourceId,
 				ImportState:       true,
 				ImportStateVerify: true,
-				Config: testConfig("testacc", "test_policy") + `
+				Config: testConfig("testacc", "test_policy", randomSuffix) + `
 resource "elasticstack_kibana_synthetics_private_location" "test" {
 	label = "pl-test-label"
 	agent_policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
@@ -78,7 +80,7 @@ resource "elasticstack_kibana_synthetics_private_location" "test" {
 			// Update and Read testing
 			{
 				SkipFunc: versionutils.CheckIfVersionIsUnsupported(minKibanaPrivateLocationAPIVersion),
-				Config: testConfig("default", "test_policy_default") + `
+				Config: testConfig("default", "test_policy_default", randomSuffix) + `
 resource "elasticstack_kibana_synthetics_private_location" "test" {
 	label = "pl-test-label-2"
 	agent_policy_id = elasticstack_fleet_agent_policy.test_policy_default.policy_id
@@ -103,7 +105,7 @@ resource "elasticstack_kibana_synthetics_private_location" "test" {
 			// Update and Read testing
 			{
 				SkipFunc: versionutils.CheckIfVersionIsUnsupported(minKibanaPrivateLocationAPIVersion),
-				Config: testConfig("default", "test_policy_default") + `
+				Config: testConfig("default", "test_policy_default", randomSuffix) + `
 resource "elasticstack_kibana_synthetics_private_location" "test" {
 	label = "pl-test-label-2"
 	agent_policy_id = elasticstack_fleet_agent_policy.test_policy_default.policy_id
@@ -119,7 +121,7 @@ resource "elasticstack_kibana_synthetics_private_location" "test" {
 			// Update and Read testing
 			{
 				SkipFunc: versionutils.CheckIfVersionIsUnsupported(minKibanaPrivateLocationAPIVersion),
-				Config: testConfig("default", "test_policy_default") + `
+				Config: testConfig("default", "test_policy_default", randomSuffix) + `
 resource "elasticstack_kibana_synthetics_private_location" "test" {
 	label = "pl-test-label-2"
 	agent_policy_id = elasticstack_fleet_agent_policy.test_policy_default.policy_id
@@ -139,7 +141,7 @@ resource "elasticstack_kibana_synthetics_private_location" "test" {
 			// Update and Read testing
 			{
 				SkipFunc: versionutils.CheckIfVersionIsUnsupported(minKibanaPrivateLocationAPIVersion),
-				Config: testConfig("default", "test_policy_default") + `
+				Config: testConfig("default", "test_policy_default", randomSuffix) + `
 resource "elasticstack_kibana_synthetics_private_location" "test" {
 	label = "pl-test-label-2"
 	agent_policy_id = elasticstack_fleet_agent_policy.test_policy_default.policy_id
@@ -162,15 +164,15 @@ resource "elasticstack_kibana_synthetics_private_location" "test" {
 	})
 }
 
-func testConfig(namespace, agentPolicy string) string {
+func testConfig(namespace, agentPolicy, randomSuffix string) string {
 	return providerConfig + fmt.Sprintf(`
 resource "elasticstack_fleet_agent_policy" "%s" {
-	name            = "Private Location Agent Policy - %s"
+	name            = "Private Location Agent Policy - %s - %s"
 	namespace       = "%s"
 	description     = "TestPrivateLocationResource Agent Policy"
 	monitor_logs    = true
 	monitor_metrics = true
 	skip_destroy    = false
 }
-`, agentPolicy, agentPolicy, namespace)
+`, agentPolicy, agentPolicy, randomSuffix, namespace)
 }