Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 14, 2019

This PR adds a page in the Stack Overview which describes how to use data frame transforms on the Kibana sample eCommerce data.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor note.
LGTM

beta[]

<<ml-dataframes,{dataframes-cap}>> enable you to retrieve information from an
{es} index, transform it, and store it in a new index. Let's use the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth to mention that it is not necessary to store it in a new index? AFAIK, you can re-use an existing index, too. Maybe to change to "...store it in an index"? Not sure though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to say store it in another index as the destination index has to be different than any of the source indices.

beta[]

<<ml-dataframes,{dataframes-cap}>> enable you to retrieve information from an
{es} index, transform it, and store it in a new index. Let's use the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to say store it in another index as the destination index has to be different than any of the source indices.

"query": {
"query_string": {
"query": "currency : EUR",
"default_operator": "AND"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to make this an actual filter

"query": {
   "bool": {
      "filter": {"term": {"currency": "EUR"}}
   }
}

Same goes for other queries used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benwtrent I've updated the preview and create data frame transform API examples to use that filter. I've also updated the query-related tip to recommend that folks use saved searches for more complex queries in Kibana.

+
--

TIP: A {dataframe-transform} increases search and indexing load on your cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to add something like Even though resource utilization is automatically adjusted based on cluster load, a {dataframe-transform}...

We adjust the pagination size of the aggregations whenever we hit a OOM circuit breaker so that we don't break due to cluster load.

@lcawl lcawl merged commit d9fdaad into elastic:master Jun 14, 2019
@lcawl lcawl deleted the pivots branch June 14, 2019 18:50
lcawl added a commit that referenced this pull request Jun 14, 2019
lcawl added a commit that referenced this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants