-
Notifications
You must be signed in to change notification settings - Fork 255
[DOCS] Adds data frame eCommerce example #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szabosteve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a minor note.
LGTM
| beta[] | ||
|
|
||
| <<ml-dataframes,{dataframes-cap}>> enable you to retrieve information from an | ||
| {es} index, transform it, and store it in a new index. Let's use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth to mention that it is not necessary to store it in a new index? AFAIK, you can re-use an existing index, too. Maybe to change to "...store it in an index"? Not sure though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to say store it in another index as the destination index has to be different than any of the source indices.
| beta[] | ||
|
|
||
| <<ml-dataframes,{dataframes-cap}>> enable you to retrieve information from an | ||
| {es} index, transform it, and store it in a new index. Let's use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to say store it in another index as the destination index has to be different than any of the source indices.
| "query": { | ||
| "query_string": { | ||
| "query": "currency : EUR", | ||
| "default_operator": "AND" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to make this an actual filter
"query": {
"bool": {
"filter": {"term": {"currency": "EUR"}}
}
}
Same goes for other queries used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benwtrent I've updated the preview and create data frame transform API examples to use that filter. I've also updated the query-related tip to recommend that folks use saved searches for more complex queries in Kibana.
| + | ||
| -- | ||
|
|
||
| TIP: A {dataframe-transform} increases search and indexing load on your cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to add something like Even though resource utilization is automatically adjusted based on cluster load, a {dataframe-transform}...
We adjust the pagination size of the aggregations whenever we hit a OOM circuit breaker so that we don't break due to cluster load.
This PR adds a page in the Stack Overview which describes how to use data frame transforms on the Kibana sample eCommerce data.