You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's my belief this is not intentional, particularly as it causes templates provided in the composable-templates entry of a track and without the top-level template field get silently filtered, the task fails with a weird error referencing request_start and there's no information in the log about what happened.
This logic should be more straightforward, providing whatever template(s) I give it as the correct parameter for the create-composable-template task.
As a hint, I think this may mean getting rid of the TemplateParamSource ABC and just spelling out each of its subclasses independently, but I haven't looked that hard at this (as you can tell by my half-hearted attempt in #1486 😄 )
The text was updated successfully, but these errors were encountered:
In https://github.com/elastic/rally/blob/master/esrally/track/params.py#L447, we assert that if and only if a provided template has the top-level key
"template"
is it a composable template. This is not true per the API, and also generally may not be maintainable to try to check spec of things before allowing to send them to Elasticsearch (and fail, and log an error).It's my belief this is not intentional, particularly as it causes templates provided in the
composable-templates
entry of a track and without the top-leveltemplate
field get silently filtered, the task fails with a weird error referencingrequest_start
and there's no information in the log about what happened.This logic should be more straightforward, providing whatever template(s) I give it as the correct parameter for the
create-composable-template
task.As a hint, I think this may mean getting rid of the
TemplateParamSource
ABC and just spelling out each of its subclasses independently, but I haven't looked that hard at this (as you can tell by my half-hearted attempt in #1486 😄 )The text was updated successfully, but these errors were encountered: