Add new ESQL CCS challenge in Logs#701
Merged
gbanasiak merged 7 commits intoelastic:masterfrom Oct 30, 2024
Merged
Conversation
favilo
approved these changes
Oct 29, 2024
Contributor
favilo
left a comment
There was a problem hiding this comment.
Left some style comments, but it looks good overall
Contributor
Author
|
@elasticmachine update branch |
luigidellaquila
approved these changes
Oct 30, 2024
Contributor
luigidellaquila
left a comment
There was a problem hiding this comment.
LGTM, thanks @gbanasiak!
I like the idea of making the tasks conditional and using them for both single cluster and CCS (rather than creating a separate set of tasks). This will ensure that we keep them aligned, so that we can compare them and evolve them together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds new
esql-ccs-snapshotchallenge inelastic/logswhich reuses existing ESQL queries but executes them in CCS context.The challenge has 2 modes of operation:
skip_esql_ccs_remote_clusters: true- queries are sent only to the local clusterskip_esql_ccs_remote_clusters: false- queries are sent only to remote clusters