Skip to content

Add new ESQL CCS challenge in Logs#701

Merged
gbanasiak merged 7 commits intoelastic:masterfrom
gbanasiak:esql-ccs
Oct 30, 2024
Merged

Add new ESQL CCS challenge in Logs#701
gbanasiak merged 7 commits intoelastic:masterfrom
gbanasiak:esql-ccs

Conversation

@gbanasiak
Copy link
Contributor

The PR adds new esql-ccs-snapshot challenge in elastic/logs which reuses existing ESQL queries but executes them in CCS context.

The challenge has 2 modes of operation:

  • skip_esql_ccs_remote_clusters: true - queries are sent only to the local cluster
  • skip_esql_ccs_remote_clusters: false - queries are sent only to remote clusters

Copy link
Contributor

@favilo favilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some style comments, but it looks good overall

@gbanasiak
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gbanasiak!

I like the idea of making the tasks conditional and using them for both single cluster and CCS (rather than creating a separate set of tasks). This will ensure that we keep them aligned, so that we can compare them and evolve them together.

@gbanasiak gbanasiak merged commit b458720 into elastic:master Oct 30, 2024
@gbanasiak gbanasiak deleted the esql-ccs branch October 30, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments