Allow _doc type in master #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic/elasticsearch#38270 made current master (7.0.0) reject mappings with type `_doc` unless `?include_type_name=true` is passed during index creation. Workaround the rejection for now by explicitly setting `include_type_name` to `true` in every create_index operation.
dliappis
added a commit
to dliappis/rally
that referenced
this pull request
Feb 6, 2019
elastic/rally-tracks#64 requires passing a parameter in the create-index runner, however, the underlying ES Python client method[1] doesn't support it. Additionally our docs[2] hint that this is possible, but it isn't. This isn't caught by unit tests as the ES client is mocked and an integration test is needed (TODO in a separate PR). Directly call es.transport.perform_request to create an index, allowing passing of any arbitrary parameter (such as `include_type_name`) to the create index Elasticsearch API. [1] https://elasticsearch-py.readthedocs.io/en/master/api.html?highlight=indices%20create#elasticsearch.client.IndicesClient.create [2] https://esrally.readthedocs.io/en/stable/track.html#create-index
Contributor
Author
|
Note that elastic/rally#642 is a prerequisite to this. |
dliappis
added a commit
to elastic/rally
that referenced
this pull request
Feb 6, 2019
elastic/rally-tracks#64 requires passing a parameter in the create-index runner, however, the underlying ES Python client method[1] doesn't support it. Additionally our docs[2] hint that this is possible, but it isn't. This isn't caught by unit tests as the ES client is mocked and an integration test is needed (TODO in a separate PR). Directly call es.transport.perform_request to create an index, allowing passing of any arbitrary parameter (such as `include_type_name`) to the create index Elasticsearch API. [1] https://elasticsearch-py.readthedocs.io/en/master/api.html?highlight=indices%20create#elasticsearch.client.IndicesClient.create [2] https://esrally.readthedocs.io/en/stable/track.html#create-index Relates #642
imotov
added a commit
to imotov/rally-tracks
that referenced
this pull request
Feb 11, 2019
Relates: elastic#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/elasticsearch#38270 made current master
(7.0.0) reject mappings with type
_docunless?include_type_name=trueis passed during index creation.Workaround the rejection for now by explicitly setting
include_type_nametotruein every create_index operation.