diff --git a/code/go/internal/validator/spec.go b/code/go/internal/validator/spec.go index e60d33810..19e38b9ed 100644 --- a/code/go/internal/validator/spec.go +++ b/code/go/internal/validator/spec.go @@ -72,8 +72,7 @@ func (s Spec) ValidatePackage(pkg Package) ve.ValidationErrors { semantic.ValidatePrerelease, semantic.ValidateFieldGroups, semantic.ValidateFieldsLimits(rootSpec.Limits.FieldsPerDataStreamLimit), - // Temporarily disabled: https://github.com/elastic/package-spec/issues/331 - //semantic.ValidateUniqueFields, + semantic.ValidateUniqueFields, semantic.ValidateDimensionFields, semantic.ValidateRequiredFields, } diff --git a/code/go/pkg/validator/validator_test.go b/code/go/pkg/validator/validator_test.go index 18fe0a426..b7f910e99 100644 --- a/code/go/pkg/validator/validator_test.go +++ b/code/go/pkg/validator/validator_test.go @@ -277,7 +277,6 @@ func TestValidateVersionIntegrity(t *testing.T) { } func TestValidateDuplicatedFields(t *testing.T) { - t.Skip("Validation temporarily disabled: https://github.com/elastic/package-spec/issues/331") tests := map[string]string{ "bad_duplicated_fields": "field \"event.dataset\" is defined multiple times for data stream \"wrong\", found in: ../../../../test/packages/bad_duplicated_fields/data_stream/wrong/fields/base-fields.yml, ../../../../test/packages/bad_duplicated_fields/data_stream/wrong/fields/ecs.yml", } diff --git a/versions/1/changelog.yml b/versions/1/changelog.yml index b67e44e94..ad6edd443 100644 --- a/versions/1/changelog.yml +++ b/versions/1/changelog.yml @@ -4,9 +4,9 @@ ## - version: 1.11.1-next changes: - - description: Prepare for next patch release - type: enhancement - link: https://github.com/elastic/package-spec/pull/353 + - description: Enable validation of duplicated fields. + type: enhancement + link: https://github.com/elastic/package-spec/pull/338 - version: 1.11.0 changes: - description: Enable development resources for input packages