Skip to content

Conversation

@karenzone
Copy link
Contributor

Updates Logstash 9.2.0 release notes to relocate known issue to proper location and make some formatting changes

Related: elastic/docs-content#3448

@karenzone karenzone self-assigned this Oct 24, 2025
@karenzone karenzone added the backport-9.2 Automated backport to the 9.2 branch label Oct 24, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

🔍 Preview links for changed docs

Comment on lines 26 to -30
### Features and enhancements [logstash-9.2.0-features-enhancements]

#### Highlights
#### Persistent queue (PQ} compression [logstash-9.2.0-pq-compression]

##### Logstash 9.2 introduces PQ compression
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three heading levels with no content inbetween can signal a structural issue. I restructured the content to [hopefully] achieve the emphasis you were going for, @robbavey, but eliminate a heading level. LMKWYT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

Comment on lines 25 to 27
**Workaround**

???
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a workaround we can recommend?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing is to not set the decode_size_limit_bytes manually, there is almost never a reason to, and I suspect there are very few people who have

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think so. This is mainly a slight change in behavior that we are pointing out. In most cases if users were configuring this limit and it was raising errors, it will continue to raise errors but in a slightly different point in the process. TLDR is that without a specific use case there is not really a generalized "workaround" to advertise.

@karenzone karenzone marked this pull request as ready for review October 24, 2025 22:21
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural changes are a big improvement. Thank you!

Comment on lines 25 to 27
**Workaround**

???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing is to not set the decode_size_limit_bytes manually, there is almost never a reason to, and I suspect there are very few people who have

Comment on lines 26 to -30
### Features and enhancements [logstash-9.2.0-features-enhancements]

#### Highlights
#### Persistent queue (PQ} compression [logstash-9.2.0-pq-compression]

##### Logstash 9.2 introduces PQ compression
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much

::::{dropdown} BufferedTokenizer may silently drop data when oversize input has no delimiters

None at this time
Applies to: {{ls}} 9.2.0
Copy link
Contributor

@mashhurs mashhurs Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move Applies to an upper level for better visibility?
Reader figures out the version when actually toggles the dropdown, but I am okay if this is a standard.

Copy link
Contributor Author

@karenzone karenzone Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree, @mashhurs. I was following the new guidelines for Known Issues used for Kibana, Beats, solutions, etc. BUT I noticed that ES format is different. I believe that, to your point, the ES model elevates relevant info and better serves the user. Stay tuned for a quick rework.


**BufferedTokenizer may silently drop data when oversize input has no delimiters**

Applies to: {{ls}} 9.2.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I tried something different based on the ES format. I did keep the Applies to: {{ls}} 9.2.0 line even though it appears redundant with the 9.2.0 heading. Thinking that we can update the line with future versions affected, or the version in which it was resolved. LMKWYT

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just awesome!
Really like it.
Thank you alot Karen.

@karenzone karenzone merged commit 163bc72 into elastic:main Oct 25, 2025
10 checks passed
@karenzone karenzone deleted the 3448-rn-9.2.0 branch October 25, 2025 00:10
@karenzone
Copy link
Contributor Author

Hmmmm, I wonder why the backport-9.2 label didn't give me a backport.
We'll need that backport for the release notes to get published. I'll look into it.

@karenzone
Copy link
Contributor Author

@Mergifyio backport 9.2

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2025

backport 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 25, 2025
karenzone added a commit that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.2 Automated backport to the 9.2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants