-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Logstash 9.2.0 release notes updates #18360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
| ### Features and enhancements [logstash-9.2.0-features-enhancements] | ||
|
|
||
| #### Highlights | ||
| #### Persistent queue (PQ} compression [logstash-9.2.0-pq-compression] | ||
|
|
||
| ##### Logstash 9.2 introduces PQ compression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three heading levels with no content inbetween can signal a structural issue. I restructured the content to [hopefully] achieve the emphasis you were going for, @robbavey, but eliminate a heading level. LMKWYT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
docs/release-notes/known-issues.md
Outdated
| **Workaround** | ||
|
|
||
| ??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a workaround we can recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing is to not set the decode_size_limit_bytes manually, there is almost never a reason to, and I suspect there are very few people who have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so. This is mainly a slight change in behavior that we are pointing out. In most cases if users were configuring this limit and it was raising errors, it will continue to raise errors but in a slightly different point in the process. TLDR is that without a specific use case there is not really a generalized "workaround" to advertise.
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structural changes are a big improvement. Thank you!
docs/release-notes/known-issues.md
Outdated
| **Workaround** | ||
|
|
||
| ??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing is to not set the decode_size_limit_bytes manually, there is almost never a reason to, and I suspect there are very few people who have
| ### Features and enhancements [logstash-9.2.0-features-enhancements] | ||
|
|
||
| #### Highlights | ||
| #### Persistent queue (PQ} compression [logstash-9.2.0-pq-compression] | ||
|
|
||
| ##### Logstash 9.2 introduces PQ compression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
donoghuc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
mashhurs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much
| ::::{dropdown} BufferedTokenizer may silently drop data when oversize input has no delimiters | ||
|
|
||
| None at this time | ||
| Applies to: {{ls}} 9.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move Applies to an upper level for better visibility?
Reader figures out the version when actually toggles the dropdown, but I am okay if this is a standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| **BufferedTokenizer may silently drop data when oversize input has no delimiters** | ||
|
|
||
| Applies to: {{ls}} 9.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I tried something different based on the ES format. I did keep the Applies to: {{ls}} 9.2.0 line even though it appears redundant with the 9.2.0 heading. Thinking that we can update the line with future versions affected, or the version in which it was resolved. LMKWYT
mashhurs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just awesome!
Really like it.
Thank you alot Karen.
|
Hmmmm, I wonder why the |
|
@Mergifyio backport 9.2 |
✅ Backports have been created
|
(cherry picked from commit 163bc72)
Co-authored-by: Karen Metts <[email protected]>
Updates Logstash 9.2.0 release notes to relocate known issue to proper location and make some formatting changes
Related: elastic/docs-content#3448