Moved Ruby Password setting to Java implementation

[andsel]

Release notes

[rn:skip]

What does this PR do?

Translates Password setting class into plain Java.

Why is it important/What is the impact to the user?

N/A

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
• I have added tests that prove my fix is effective or that my feature works

Author's Checklist

• [ ]

How to test this PR locally

Enable http basic authentication and try to connect.
Update logstash.yml with:

api.auth.type: basic
api.auth.basic.username: "logstash-user"
api.auth.basic.password: "s3cUreP4$$w0rD

Try to connect without user credentials header and verify that you don't have access.
Try with credentials and it works:

curl -v -u 'logstash-user:s3cUreP4$$w0rD' http://localhost:9600/_node/stats | jq .pipelines.main

Related issues

• Closes Reimplement LogStash::Setting::Password to Java #18182

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
• If no backport is necessary, please add the backport-skip label

[Copilot]

Pull Request Overview

Migrates the Ruby Password setting class to a Java implementation to improve performance and maintainability. The change translates the existing Ruby LogStash::Setting::Password class into a plain Java PasswordSetting class while maintaining the same functionality and API.

• Implemented PasswordSetting in Java with identical coercion and validation logic
• Updated Ruby code to use the Java implementation via java_import
• Added comprehensive test coverage for the new Java implementation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
logstash-core/src/main/java/org/logstash/settings/PasswordSetting.java	New Java implementation of password setting with coercion logic
logstash-core/src/test/java/org/logstash/settings/PasswordSettingTest.java	Test suite covering password setting validation and coercion scenarios
logstash-core/lib/logstash/settings.rb	Removed Ruby Password class and imported Java PasswordSetting
logstash-core/lib/logstash/environment.rb	Updated references to use PasswordSetting instead of Password
logstash-core/spec/logstash/settings/password_spec.rb	Updated test to expect IllegalArgumentException instead of ArgumentError

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[jsvd]

LGTM, just address the whitespace and when typoes!

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 4cf3479

History

• 💚 Build #3521 succeeded 44c3a7c

cc @andsel