Apply suggestions from code review

Warning and error messages well formatted.

Co-authored-by: Rye Biesemeyer <[email protected]>

Author: mashhurs

logstash-core/src/main/java/org/logstash/secret/SecretIdentifier.java

@@ -123,7 +123,7 @@ private static void validateKey(final String key, final String keyName) {
         }
 
         if (!ConfigVariableExpander.KEY_PATTERN.matcher(key).matches()) {
-            logger.warn(String.format("Invalid secret key name `%s` provided.", key) + ConfigVariableExpander.KEY_PATTERN_DESCRIPTION);
+            logger.warn(String.format("Invalid secret key name `%s` provided. %s", key, ConfigVariableExpander.KEY_PATTERN_DESCRIPTION));
         }
     }
 

logstash-core/src/main/java/org/logstash/secret/cli/SecretStoreCli.java

@@ -263,7 +263,7 @@ public void command(String primaryCommand, SecureConfig config, String... allArg
                     final SecretStore secretStore = secretStoreFactory.load(config);
                     for (String argument : commandLine.getArguments()) {
                         if (!ConfigVariableExpander.KEY_PATTERN.matcher(argument).matches()) {
-                            throw new IllegalArgumentException(String.format("Invalid secret key name `%s` provided.", argument) + ConfigVariableExpander.KEY_PATTERN_DESCRIPTION);
+                            throw new IllegalArgumentException(String.format("Invalid secret key name `%s` provided. %s", argument, ConfigVariableExpander.KEY_PATTERN_DESCRIPTION);
                         }
                         final SecretIdentifier id = new SecretIdentifier(argument);
                         final byte[] existingValue = secretStore.retrieveSecret(id);