From e535ca807d53d33d3424492d286b420263d4e756 Mon Sep 17 00:00:00 2001 From: lcawl Date: Mon, 19 Apr 2021 14:45:31 -0700 Subject: [PATCH 1/2] [ML] Add tooltips for actual and typical in anomalies table --- .../anomalies_table/anomalies_table.test.js | 4 +-- .../anomalies_table_columns.js | 36 +++++++++++++++---- 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table.test.js b/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table.test.js index 7f1ac9243e853..2b3e14308497a 100644 --- a/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table.test.js +++ b/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table.test.js @@ -81,10 +81,10 @@ describe('AnomaliesTable', () => { name: 'influenced by', }), expect.objectContaining({ - name: 'actual', + field: 'actualSort', }), expect.objectContaining({ - name: 'typical', + field: 'typicalSort', }), expect.objectContaining({ name: 'description', diff --git a/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js b/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js index f1093fd0b16a1..f0314928d700d 100644 --- a/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js +++ b/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js @@ -5,7 +5,7 @@ * 2.0. */ -import { EuiButtonIcon, EuiLink, EuiScreenReaderOnly } from '@elastic/eui'; +import { EuiButtonIcon, EuiLink, EuiScreenReaderOnly, EuiToolTip, EuiIcon } from '@elastic/eui'; import React from 'react'; import { get } from 'lodash'; @@ -178,9 +178,20 @@ export function getColumns( columns.push({ field: 'actualSort', 'data-test-subj': 'mlAnomaliesListColumnActual', - name: i18n.translate('xpack.ml.anomaliesTable.actualSortColumnName', { - defaultMessage: 'actual', - }), + name: ( + + + {i18n.translate('xpack.ml.anomaliesTable.actualSortColumnName', { + defaultMessage: 'Actual', + })} + + + + ), render: (actual, item) => { const fieldFormat = mlFieldFormatService.getFieldFormat( item.jobId, @@ -196,9 +207,20 @@ export function getColumns( columns.push({ field: 'typicalSort', 'data-test-subj': 'mlAnomaliesListColumnTypical', - name: i18n.translate('xpack.ml.anomaliesTable.typicalSortColumnName', { - defaultMessage: 'typical', - }), + name: ( + + + {i18n.translate('xpack.ml.anomaliesTable.typicalSortColumnName', { + defaultMessage: 'Typical', + })} + + + + ), render: (typical, item) => { const fieldFormat = mlFieldFormatService.getFieldFormat( item.jobId, From 3907ff42e272d991eb48bc23056d02ffb7778782 Mon Sep 17 00:00:00 2001 From: lcawl Date: Tue, 20 Apr 2021 08:15:12 -0700 Subject: [PATCH 2/2] Addresses feedback --- .../components/anomalies_table/anomalies_table_columns.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js b/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js index f0314928d700d..0e810ec0dfdc2 100644 --- a/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js +++ b/x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js @@ -181,7 +181,7 @@ export function getColumns( name: ( @@ -210,7 +210,7 @@ export function getColumns( name: (