Skip to content

Conversation

@YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Feb 24, 2021

Added missing README information for the new API added by the PR

  • Documentation was added for features that require explanation or tutorials

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs Feature:EventLog v7.12.0 labels Feb 24, 2021
@YulNaumenko YulNaumenko requested a review from a team as a code owner February 24, 2021 05:06
@YulNaumenko YulNaumenko self-assigned this Feb 24, 2021
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM after the changes I've proposed 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko requested a review from gchaps February 25, 2021 01:00
@YulNaumenko YulNaumenko merged commit bd38d4a into elastic:master Feb 25, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 25, 2021
…tiple-searchable-snapshot-actions

* 'master' of github.com:elastic/kibana:
  [Rollup] Fix use of undefined value in JS import (elastic#92791)
  [ILM] Fix replicas not showing  (elastic#92782)
  [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract. (elastic#92562)
  [XY] Enables page reload toast for the legacyChartsLibrary setting (elastic#92811)
  [Security Solution][Case] Improve hooks (elastic#89580)
  [Security Solution] Update wordings and breadcrumb for timelines page (elastic#90809)
  [Security Solution] Replace EUI theme with mocks in jest suites (elastic#92462)
  docs: ✏️ use correct heading level (elastic#92806)
  [ILM ] Fix logic for showing/hiding recommended allocation on Cloud (elastic#90592)
  [Security Solution][Detections] Pull gap detection logic out in preparation for sharing between rule types (elastic#91966)
  [core.savedObjects] Remove _shard_doc tiebreaker since ES now adds it automatically. (elastic#92295)
  docs: ✏️ fix links in embeddable plugin readme (elastic#92778)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Feb 25, 2021
…and Start plugin contract. (elastic#92562)

* [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract.

* Apply suggestions from code review

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>

* fixed due to comments

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Feb 25, 2021
…and Start plugin contract. (elastic#92562)

* [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract.

* Apply suggestions from code review

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>

* fixed due to comments

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit that referenced this pull request Feb 25, 2021
…and Start plugin contract. (#92562) (#92862)

* [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract.

* Apply suggestions from code review

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>

* fixed due to comments

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit that referenced this pull request Feb 25, 2021
…and Start plugin contract. (#92562) (#92863)

* [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract.

* Apply suggestions from code review

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>

* fixed due to comments

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Mike Côté <[email protected]>
Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Feature:EventLog release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants