Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 24.4.0 -> 24.5.1 age adoption passing confidence

Release Notes

elastic/elastic-charts

v24.5.1

Compare Source

Bug Fixes

v24.5.0

Compare Source

Bug Fixes
Features

v24.4.1

Compare Source

Bug Fixes

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Kibana-Operations Team v7.11.0 v8.0.0 labels Jan 30, 2021
@renovate renovate bot requested a review from markov00 January 30, 2021 16:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from acb5998 to 4419c18 Compare February 5, 2021 10:50
@renovate renovate bot changed the title Update dependency @elastic/charts to v24.5.0 Update dependency @elastic/charts to v24.5.1 Feb 5, 2021
@renovate renovate bot requested a review from a team February 5, 2021 13:52
@renovate renovate bot requested review from a team as code owners February 5, 2021 13:52
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana App code LGTM, I can also confirm that this bug can close when this PR is merged
image

@flash1293 do you want to check anything else from Lens side?

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@LeeDr LeeDr added v7.12.0 and removed v7.11.0 labels Feb 8, 2021
@markov00
Copy link
Member

markov00 commented Feb 9, 2021

@elasticmachine merge upstream

@markov00
Copy link
Member

markov00 commented Feb 9, 2021

@nickofthyme I've found this issue verifying the functional tests: 8d00a45
When using a non-time-based index, the getBounds method from the Timefilter always returns a range, independently if it exists or not (on non-time-based indices, the time filter is disabled by you can create a date histogram). This creates a rendering issue where the chart now covers a range from the beginning of the dataset (2015 for this test) to now. Using the getActiveBounds the min/max props for xDomain are not configured rendering the chart correctly.

@markov00
Copy link
Member

markov00 commented Feb 9, 2021

@elasticmachine merge upstream

@nickofthyme nickofthyme linked an issue Feb 10, 2021 that may be closed by this pull request
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1736 1730 -6
visTypeXy 107 101 -6
total -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB -10.2KB
visTypeXy 140.8KB 130.5KB -10.3KB
total -20.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 467.9KB 470.1KB +2.2KB
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
[email protected] 2.4MB 2.5MB +32.6KB
kbn-ui-shared-deps.js 7.0MB 7.0MB -5.5KB
total +27.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 merged commit 57d9dd1 into master Feb 11, 2021
@renovate renovate bot deleted the renovate/@elasticcharts branch February 11, 2021 08:20
markov00 added a commit to markov00/kibana that referenced this pull request Feb 11, 2021
Updates @elastic/charts to 24.5.1 with some Kibana related fixes:
- align tooltip z-index to EUI tooltip z-index
- external tooltip legend extra value sync
- legend: hierarchical legend order should follow the tree paths


fix elastic#84307

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 11, 2021
* master: (44 commits)
  [APM] Add experimental support for Data Streams (elastic#89650)
  [Search Session] Control "Kibana / Search Sessions" management section by privileges (elastic#90818)
  [Lens] Median as default function (elastic#90952)
  Implement custom global header banner (elastic#87438)
  [Fleet] Reduce permissions. (elastic#90302)
  Update dependency @elastic/charts to v24.5.1 (elastic#89822)
  [Create index pattern] Can't create single character index without wildcard (elastic#90919)
  [ts/build_ts_refs] add support for --clean flag (elastic#91060)
  Don't clean when running e2e tests (elastic#91057)
  Fixes track_total_hits in the body not having an effect when using search strategy (elastic#91068)
  [Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege (elastic#90895)
  Removing the code plugin entirely for 8.0 (elastic#77940)
  chore(NA): move the instruction to remove yarn global bazelisk package into the first place on install bazel tools (elastic#91026)
  [jest/ci] remove max-old-space-size override to use 4gb default (elastic#91020)
  [Fleet] Restrict integration changes for managed policies (elastic#90675)
  [CI] Fix auto-backport condditions so that it doesn't trigger for other labels (elastic#91042)
  [DOCS] Uses variable to refer to query profiler (elastic#90976)
  [App Search] Relevance Tuning logic listeners (elastic#89461)
  [Metrics UI] Fix saving/loading saved views from URL (elastic#90216)
  Limit cardinality of transaction.name (elastic#90955)
  ...
markov00 added a commit that referenced this pull request Feb 11, 2021
Updates @elastic/charts to 24.5.1 with some Kibana related fixes:
- align tooltip z-index to EUI tooltip z-index
- external tooltip legend extra value sync
- legend: hierarchical legend order should follow the tree paths


fix #84307

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Operations Kibana-Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TSVB] Synced tooltip is not shown in dashboard

10 participants