Skip to content

Add basepath when redirecting from a trailling slash#8966

Merged
jbudz merged 1 commit intoelastic:masterfrom
jbudz:redirect-basepath
Nov 10, 2016
Merged

Add basepath when redirecting from a trailling slash#8966
jbudz merged 1 commit intoelastic:masterfrom
jbudz:redirect-basepath

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented Nov 4, 2016

Routes with a trailing slash are redirected with the trailing slash removed. These redirects were not including the server base path causing paths like /my_base_path/app/kibana/ -> /app/kibana

spalger
spalger approved these changes Nov 5, 2016
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epixa
Copy link
Contributor

epixa commented Nov 5, 2016

Is basePath guaranteed to end in a /? What about if it's simply /?

@jbudz
Copy link
Contributor Author

jbudz commented Nov 7, 2016

There's some schema validation for it, it'll fail if it ends with a trailing / (or there is only a /)

kibana/src/server/config/schema.js

Line 42 in aa69744

basePath: Joi.string().default('').allow('').regex(/(^$|^\/.*[^\/]$)/, `start with a slash, don't end with one`),
.

@epixa epixa added the v4.7.0 label Nov 7, 2016
@jbudz jbudz merged commit 6236843 into elastic:master Nov 10, 2016
@epixa epixa added v5.0.1 and removed v5.0.2 labels Nov 10, 2016
elastic-jasper added a commit that referenced this pull request Nov 10, 2016
@elastic-jasper
Add basepath when redirecting from a trailling slash
d1e387e 
Backports PR #8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z
elastic-jasper added a commit that referenced this pull request Nov 10, 2016
@elastic-jasper
Add basepath when redirecting from a trailling slash
04aee43 
Backports PR #8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z
elastic-jasper added a commit that referenced this pull request Nov 10, 2016
@elastic-jasper
Add basepath when redirecting from a trailling slash
c69c272 
Backports PR #8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z
This was referenced Nov 10, 2016
Merged
Merged
Merged
jbudz pushed a commit that referenced this pull request Nov 10, 2016
@elastic-jasper @jbudz
Add basepath when redirecting from a trailling slash (#9035)
9da1f6c 
Backports PR #8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z
jbudz pushed a commit that referenced this pull request Nov 10, 2016
@elastic-jasper @jbudz
Add basepath when redirecting from a trailling slash (#9033)
321e7e5 
Backports PR #8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z
jbudz pushed a commit that referenced this pull request Nov 10, 2016
@elastic-jasper @jbudz
Add basepath when redirecting from a trailling slash (#9034)
5d24220 
Backports PR #8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 10, 2016
@jbudz @nreese
Add basepath when redirecting from a trailling slash (elastic#8966)
9c331c5
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
@epixa epixa added the v4.6.4 label Dec 20, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@elastic-jasper @jbudz
Add basepath when redirecting from a trailling slash (elastic#9033)
3ca8541 
Backports PR elastic#8966

**Commit 1:**
Add basepath when redirecting from a trailling slash

* Original sha: 442bcb9
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z

Former-commit-id: 321e7e5
mgadewoll added a commit that referenced this pull request Aug 27, 2025
@mgadewoll
Upgrade EUI to v106.4.0 (#232774)
e8bfa97 
- `@elastic/eui`: `v106.3.0` ⏩ `v106.4.0`
- `@elastic/eui-theme-borealis`: `v3.3.1` ⏩ `v3.3.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.4.0`](https://github.com/elastic/eui/releases/v106.4.0)

- Added prop `focusTrapProps` on `EuiModal`
([#8945](elastic/eui#8945))

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([#8966](elastic/eui#8966))
- Fixed `restrictWidth` not applying to `EuiPageHeaderContent` when only
`children` are used as content
([#8965](elastic/eui#8965))

**Accessibility**

- Fixed an issue where pressing Shift + Tab on the last tabbable element
inside `EuiInputPopover` popover would close the popover unexpectedly
([#8950](elastic/eui#8950))

### `@elastic/eui-theme-borealis`

## [`v3.3.2`](https://github.com/elastic/eui/releases/v3.3.2)

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([#8966](elastic/eui#8966))
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Aug 30, 2025
@mgadewoll @kowalczyk-krzysztof
Upgrade EUI to v106.4.0 (elastic#232774)
6f2abdc 
- `@elastic/eui`: `v106.3.0` ⏩ `v106.4.0`
- `@elastic/eui-theme-borealis`: `v3.3.1` ⏩ `v3.3.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.4.0`](https://github.com/elastic/eui/releases/v106.4.0)

- Added prop `focusTrapProps` on `EuiModal`
([elastic#8945](elastic/eui#8945))

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
- Fixed `restrictWidth` not applying to `EuiPageHeaderContent` when only
`children` are used as content
([elastic#8965](elastic/eui#8965))

**Accessibility**

- Fixed an issue where pressing Shift + Tab on the last tabbable element
inside `EuiInputPopover` popover would close the popover unexpectedly
([elastic#8950](elastic/eui#8950))

### `@elastic/eui-theme-borealis`

## [`v3.3.2`](https://github.com/elastic/eui/releases/v3.3.2)

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
qn895 pushed a commit to qn895/kibana that referenced this pull request Sep 2, 2025
@mgadewoll @qn895
Upgrade EUI to v106.4.0 (elastic#232774)
ce920ee 
- `@elastic/eui`: `v106.3.0` ⏩ `v106.4.0`
- `@elastic/eui-theme-borealis`: `v3.3.1` ⏩ `v3.3.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.4.0`](https://github.com/elastic/eui/releases/v106.4.0)

- Added prop `focusTrapProps` on `EuiModal`
([elastic#8945](elastic/eui#8945))

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
- Fixed `restrictWidth` not applying to `EuiPageHeaderContent` when only
`children` are used as content
([elastic#8965](elastic/eui#8965))

**Accessibility**

- Fixed an issue where pressing Shift + Tab on the last tabbable element
inside `EuiInputPopover` popover would close the popover unexpectedly
([elastic#8950](elastic/eui#8950))

### `@elastic/eui-theme-borealis`

## [`v3.3.2`](https://github.com/elastic/eui/releases/v3.3.2)

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spalger spalger

Labels

review v4.6.4 v5.0.1 v5.1.1 v6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbudz @epixa @spalger

Comments