Skip to content

Fixed regex bug in Safari #89399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fixed regex bug in Safari #89399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
716ebd3
Fixed regex bug in Safari
thomheymann Jan 27, 2021
cd2e4cd
Added extra unit test
thomheymann Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const NEXT_URL_QUERY_STRING_PARAMETER = 'next';
* - Must contain only letters, numbers, spaces, punctuation and printable symbols.
* - Must not contain leading or trailing spaces.
*/
export const NAME_REGEX = /^(?! )[a-zA-Z0-9 !"#$%&'()*+,\-./\\:;<=>?@\[\]^_`{|}~]+(?<! )$/;
export const NAME_REGEX = /^(?! )[a-zA-Z0-9 !"#$%&'()*+,\-./\\:;<=>?@\[\]^_`{|}~]*[a-zA-Z0-9!"#$%&'()*+,\-./\\:;<=>?@\[\]^_`{|}~]$/;
Copy link
Member

@azasypkin azasypkin Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: hmm, it doesn't look like we have any tests that validate this "no trailing whitespace" requirement or I missed that? If true, would you mind adding some?

Copy link
Contributor Author

@thomheymann thomheymann Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I've added that in


/**
* Maximum length of usernames and role names.
Expand Down
6 changes: 6 additions & 0 deletions x-pack/plugins/security/public/management/users/edit_user/create_user_page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ describe('CreateUserPage', () => {

await findAllByText(/Username must not contain leading or trailing spaces/i);

fireEvent.change(await findByLabelText('Username'), {
target: { value: 'username_with_trailing_space ' },
});

await findAllByText(/Username must not contain leading or trailing spaces/i);

fireEvent.change(await findByLabelText('Username'), {
target: { value: '€' },
});
Expand Down