From 911855b8dcc755a6d36086b00c634540c884f10f Mon Sep 17 00:00:00 2001 From: Ryland Herrick Date: Wed, 2 Dec 2020 21:15:50 -0600 Subject: [PATCH 1/2] Remove nonexistent paths from our API tests config These paths (or rather their absence) breaks the functional_tests_server script. An analogous problem for cases was fixed in #79127. --- .../test/detection_engine_api_integration/common/config.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/x-pack/test/detection_engine_api_integration/common/config.ts b/x-pack/test/detection_engine_api_integration/common/config.ts index c21e6d0fdecf0..4d890b6edbbae 100644 --- a/x-pack/test/detection_engine_api_integration/common/config.ts +++ b/x-pack/test/detection_engine_api_integration/common/config.ts @@ -4,7 +4,6 @@ * you may not use this file except in compliance with the Elastic License. */ -import path from 'path'; import { CA_CERT_PATH } from '@kbn/dev-utils'; import { FtrConfigProviderContext } from '@kbn/test/types/ftr'; import { services } from './services'; @@ -71,10 +70,6 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions) `--xpack.actions.enabledActionTypes=${JSON.stringify(enabledActionTypes)}`, '--xpack.eventLog.logEntries=true', ...disabledPlugins.map((key) => `--xpack.${key}.enabled=false`), - `--plugin-path=${path.join(__dirname, 'fixtures', 'plugins', 'alerts')}`, - `--plugin-path=${path.join(__dirname, 'fixtures', 'plugins', 'actions')}`, - `--plugin-path=${path.join(__dirname, 'fixtures', 'plugins', 'task_manager')}`, - `--plugin-path=${path.join(__dirname, 'fixtures', 'plugins', 'aad')}`, ...(ssl ? [ `--elasticsearch.hosts=${servers.elasticsearch.protocol}://${servers.elasticsearch.hostname}:${servers.elasticsearch.port}`, From 6e39cccc1c4557a8faec53fc19dac2213afff8c6 Mon Sep 17 00:00:00 2001 From: Ryland Herrick Date: Fri, 4 Dec 2020 12:39:45 -0600 Subject: [PATCH 2/2] Remove duplicated context from logger This context is already provided to the logger by kibana; adding it a second time leads to duplicated log tags, e.g.: ``` server log [12:36:07.138] [debug][plugins][plugins][securitySolution][securitySolution] ... ``` This is now fixed: ``` server log [12:41:52.112] [debug][plugins][securitySolution] ... ``` --- x-pack/plugins/security_solution/server/plugin.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/security_solution/server/plugin.ts b/x-pack/plugins/security_solution/server/plugin.ts index 10e817bea0282..b8676893d8ba1 100644 --- a/x-pack/plugins/security_solution/server/plugin.ts +++ b/x-pack/plugins/security_solution/server/plugin.ts @@ -135,7 +135,7 @@ export class Plugin implements IPlugin