Skip to content

[Observability] Fix telemetry for Observability Overview #83847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2020
Merged

[Observability] Fix telemetry for Observability Overview #83847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9f4c66
[Observability] Fix telemetry for Observability Overview
sorenlouv Nov 19, 2020
86df98e
Fix tsc issue
sorenlouv Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/observability/public/pages/landing/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const EuiCardWithoutPadding = styled(EuiCard)`
`;

export function LandingPage() {
useTrackPageview({ app: 'observability', path: 'landing' });
useTrackPageview({ app: 'observability', path: 'landing', delay: 15000 });
useTrackPageview({ app: 'observability-overview', path: 'landing' });
useTrackPageview({ app: 'observability-overview', path: 'landing', delay: 15000 });

const { core } = usePluginContext();
const theme = useContext(ThemeContext);
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/observability/public/pages/overview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export function OverviewPage({ routeParams }: Props) {
end: getAbsoluteTime(relativeTime.end, { roundUp: true }) as number,
};

useTrackPageview({ app: 'observability', path: 'overview' });
useTrackPageview({ app: 'observability', path: 'overview', delay: 15000 });
useTrackPageview({ app: 'observability-overview', path: 'overview' });
useTrackPageview({ app: 'observability-overview', path: 'overview', delay: 15000 });

const { data: alerts = [], status: alertStatus } = useFetcher(() => {
return getObservabilityAlerts({ core });
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/observability/public/typings/fetch_overview_data/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export type HasData = (params?: HasDataParams) => Promise<HasDataResponse>;

export type ObservabilityFetchDataPlugins = Exclude<
ObservabilityApp,
'observability' | 'stack_monitoring'
'observability-overview' | 'stack_monitoring'
>;

export interface DataHandler<
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/observability/typings/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export type ObservabilityApp =
| 'infra_logs'
| 'apm'
| 'uptime'
| 'observability'
| 'observability-overview'
| 'stack_monitoring'
| 'ux';

Expand Down