[kbn/plugin-helpers/build] copy the public assets of a plugin #83458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Nov 16, 2020
…c#83458) Co-authored-by: spalger <[email protected]>
This was referenced Nov 16, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Nov 16, 2020
…c#83458) Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Nov 16, 2020
…83458) (#83494) Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Nov 16, 2020
…83458) (#83493) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83387
The updates to the plugin helpers in #75019 added a filter for the public directory when copying the server files for third-party plugins. This excluded the
public/assetsdirectory which the server exposes to the front-end at{basePath}/plugins/{id}/assets/{path}. This copies those files over as a new step in the build process.