Skip to content

[Uptime] Fix monitor list down histogram #83411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2020
Merged

[Uptime] Fix monitor list down histogram #83411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccde474
Fix monitor list down histogram
shahzad31 Nov 16, 2020
a8d741b
snapshots
shahzad31 Nov 16, 2020
f2c1c09
UP
shahzad31 Nov 16, 2020
118cc48
UP
shahzad31 Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/uptime/server/lib/requests/get_monitor_states.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const getHistogramForMonitors = async (
},
},
};
const result = await queryContext.search(params);
const { body: result } = await queryContext.search(params);

const histoBuckets: any[] = result.aggregations?.histogram.buckets ?? [];
const simplified = histoBuckets.map((histoBucket: any): { timestamp: number; byId: any } => {
Expand Down
369 changes: 369 additions & 0 deletions x-pack/test/api_integration/apis/uptime/rest/__snapshots__/monitor_states_real_data.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions x-pack/test/api_integration/apis/uptime/rest/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,15 @@ import {
settingsObjectId,
settingsObjectType,
} from '../../../../../plugins/uptime/server/lib/saved_objects';
import { registerMochaHooksForSnapshots } from '../../../../apm_api_integration/common/match_snapshot';

export default function ({ getService, loadTestFile }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const server = getService('kibanaServer');

describe('uptime REST endpoints', () => {
registerMochaHooksForSnapshots();

beforeEach('clear settings', async () => {
try {
await server.savedObjects.delete({
Expand Down
Loading