Excludes node_modules from packer cache #83337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
reviewed
Nov 12, 2020
spalger
reviewed
Nov 12, 2020
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
packer-no-modules
branch
from
f7802b3 to
8d8a39b
Compare
Contributor
Author
|
Verified this here: #83323 (comment) |
Contributor
Author
|
No longer needed, we just built new images. |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should rely on the offline cache within the package image to populate the node modules, not the actual node module folders. Without this, we're seeing discrepencies when modules change.