-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Solution][Case] Manual attach alert to a case #82996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c47de24
Switch to panels
cnasikas 53f08eb
Add case panel
cnasikas 1496e19
Attach alert to new case
cnasikas ad4b89d
Delete unused modal
cnasikas 6a92d53
Improve create case modal
cnasikas 5c421db
Remove onRowClick logic from modal
cnasikas bdcee07
Attach alert to existing case
cnasikas 9564c6e
Fix types
cnasikas 260e804
Fix tests
cnasikas 3e2bec9
Fix cypress tests
cnasikas 722c7cf
Create add alert to case timeline action
cnasikas 0db4715
Fixes
cnasikas f922313
Revert "Switch to panels"
cnasikas 7550390
Fix rebase
cnasikas 1da1728
Improve modals
cnasikas a3bdebf
Improve tests
cnasikas 39c42f0
Add constant
cnasikas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -437,7 +437,44 @@ describe('AllCases', () => { | |
| ); | ||
| await waitFor(() => { | ||
| wrapper.find('[data-test-subj="cases-table-row-1"]').first().simulate('click'); | ||
| expect(onRowClick).toHaveBeenCalledWith('1'); | ||
| expect(onRowClick).toHaveBeenCalledWith({ | ||
| closedAt: null, | ||
| closedBy: null, | ||
| comments: [], | ||
| connector: { fields: null, id: '123', name: 'My Connector', type: '.none' }, | ||
| createdAt: '2020-02-19T23:06:33.798Z', | ||
| createdBy: { | ||
| email: '[email protected]', | ||
| fullName: 'Leslie Knope', | ||
| username: 'lknope', | ||
| }, | ||
| description: 'Security banana Issue', | ||
| externalService: { | ||
| connectorId: '123', | ||
| connectorName: 'connector name', | ||
| externalId: 'external_id', | ||
| externalTitle: 'external title', | ||
| externalUrl: 'basicPush.com', | ||
| pushedAt: '2020-02-20T15:02:57.995Z', | ||
| pushedBy: { | ||
| email: '[email protected]', | ||
| fullName: 'Leslie Knope', | ||
| username: 'lknope', | ||
| }, | ||
| }, | ||
| id: '1', | ||
| status: 'open', | ||
| tags: ['coke', 'pepsi'], | ||
| title: 'Another horrible breach!!', | ||
| totalComment: 0, | ||
| updatedAt: '2020-02-20T15:02:57.995Z', | ||
| updatedBy: { | ||
| email: '[email protected]', | ||
| fullName: 'Leslie Knope', | ||
| username: 'lknope', | ||
| }, | ||
| version: 'WzQ3LDFd', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
153 changes: 0 additions & 153 deletions
153
x-pack/plugins/security_solution/public/cases/components/all_cases_modal/index.test.tsx
This file was deleted.
Oops, something went wrong.
57 changes: 0 additions & 57 deletions
57
x-pack/plugins/security_solution/public/cases/components/all_cases_modal/index.tsx
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
x-pack/plugins/security_solution/public/cases/components/all_cases_modal/translations.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.