Skip to content

Conversation

@pzl
Copy link
Member

@pzl pzl commented Nov 6, 2020

Summary

Traditional offset paging has an elasticsearch paging limit of 10k objects. This will show a notice to the user that the first 10k results will be shown, if more exist.

2020-11-12-133214_scrot

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@pzl pzl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature v7.11.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Nov 6, 2020
@pzl pzl requested review from a team as code owners November 6, 2020 20:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@pzl pzl marked this pull request as draft November 6, 2020 20:58
@pzl
Copy link
Member Author

pzl commented Nov 9, 2020

@elasticmachine merge upstream

@pzl pzl force-pushed the ep-10k-page-limit branch from ce8e9b4 to 5906152 Compare November 10, 2020 20:02
@pzl
Copy link
Member Author

pzl commented Nov 10, 2020

@elasticmachine merge upstream

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to come to an agreement on this text

@pzl pzl force-pushed the ep-10k-page-limit branch from eacfcc7 to 985cded Compare November 12, 2020 18:33
@pzl pzl marked this pull request as ready for review November 12, 2020 18:37
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.9MB 7.9MB +480.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pzl pzl merged commit d52415c into elastic:master Nov 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 16, 2020
* master:
  [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462)
  [Enterprise Search] Share Loading component (elastic#83246)
  Consolidates Jest configuration files and scripts (elastic#82671)
  APM header changes (elastic#82870)
  [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727)
  [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889)
  [packerCache] fix gulp usage, don't archive node_modules (elastic#83327)
  Upgrade Node.js to version 12 (elastic#61587)
  [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734)
  [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011)
  [DOCS] Updates Discover docs (elastic#82773)
  [ML] Data frame analytics: Adds map view (elastic#81666)
  enables actions scoped within the stack to register at Basic license (elastic#82931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants