[Discover] Deangularize context_app.html, part 3 #81838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@elasticmachine merge upstream |
majagrubic
added
v7.11
release_note:skip
andreadelrio
requested changes
Oct 28, 2020
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/context_app/context_app_legacy.scss
Outdated
Show resolved
Hide resolved
…/context_app_legacy.scss Co-authored-by: Andrea Del Rio <[email protected]>
…/context_app_legacy.tsx Co-authored-by: Andrea Del Rio <[email protected]>
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
kertal
approved these changes
Nov 2, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally in Chrome, FF, Safari, works as expected 👍 Think you can also remove action_bar_directive.ts.
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 2, 2020
* master: Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) Rename "service overview" to "service inventory" (elastic#81933) adjust policy test to drop test for server addresses (elastic#82120) Cleanup/codeowners (elastic#82146) [DOCS] Updates add data content (elastic#81093) [DOCS] Remove index mgmt docs (elastic#82099) [Search] fix cancelation related memory leaks (elastic#81996)
majagrubic
pushed a commit
that referenced
this pull request
Nov 2, 2020
* [Discover] Deangularize context_app.html * Removing unnecessary empty line * Reintroduce not loading if status == FAILED * Update src/plugins/discover/public/application/components/context_app/context_app_legacy.scss Co-authored-by: Andrea Del Rio <[email protected]> * Update src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx Co-authored-by: Andrea Del Rio <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Andrea Del Rio <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Andrea Del Rio <[email protected]>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 2, 2020
…e-details-overlay * 'master' of github.com:elastic/kibana: (72 commits) [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487) [APM] Scale transaction rate correctly (elastic#82155) Upgrade to hapi version 18 (elastic#80468) [Uptime] Remove custom handling of license enabling (elastic#82019) [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579) Enable send to background in Vega (elastic#82229) Enable send to background in Timelion (elastic#82232) [Actions & Connectors] removes Connector flyouts after usage (elastic#82126) Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: #70211
Moves remaining Angular directives into
ContextAppLegacyReact component.Checklist
Delete any items that are not applicable to this PR.
- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers