[kbn/bootstrap] validate that certain deps don't ship in production #80549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
TinaHeiligers
approved these changes
Oct 15, 2020
Contributor
TinaHeiligers
left a comment
TinaHeiligers
left a comment
There was a problem hiding this comment.
telemetry-tools changes LGTM
mshustov
approved these changes
Oct 15, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 15, 2020
…lastic#80549) Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-pm/dist/index.js
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 15, 2020
…lastic#80549) Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-pm/dist/index.js # packages/kbn-pm/src/commands/bootstrap.ts
spalger
added a commit
that referenced
this pull request
Oct 15, 2020
…tion (#80549) (#80710) Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-pm/dist/index.js
spalger
added a commit
that referenced
this pull request
Oct 15, 2020
…ction (#80549) (#80712) Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@restrry discovered in #80463 that we're shipping
@kbn/dev-utilsin production, so I figured it was time to start validating that certain packages stay dev only.This adds a check to
yarn kbn bootstrapto look for packages in the tree of production dependencies forkibanaandx-packwhich are flagged with a newkibana.devOnlyproperty (in their package.json).To start I've labeled the following packages as dev only:
@elastic/eslint-config-kibana@kbn/babel-preset@kbn/dev-utils@kbn/es@kbn/es-archiver@kbn/eslint-import-resolver-kibana@kbn/eslint-plugin-eslint@kbn/expect@kbn/pm@kbn/release-notes@kbn/storybook@kbn/telemetry-tools@kbn/test@kbn/test-subj-selector@kbn/utility-typesWhen these packages make their way into the production dependency chain we print out an error that includes a map to help people understand where the issue is and help them fix it: