Skip to content

Conversation

@qn895
Copy link
Member

@qn895 qn895 commented Oct 5, 2020

Backports the following commits to 7.x:

[ML] Migrate machine learning URLs to BrowserRouter format for APM, S… (#78209)

…ecurity, and Infra (elastic#78209)

* [ML] Adds ability to pass multiple jobIds to job management url

* [ML][APM] Update links to jobs management page for MLLink and LegacyJobsCallout

* [ML][APM] Update useTimeSeriesExplorerHref

* [ML][APM] Update tests

* [ML][APM] Move test from useTimeSeriesExplorerHref to MLJobLink.test.tsx

* [ML][Infra] Update ML links in infra to non-hash paths

* [ML] Move MlUrlGenerator registration outside of licensing block for security solution

* [ML][Security] Update ml links in security

* [ML][APM] Update test snapshots

* [ML][APM] Update snapshots

* [ML][Security solution] Update tests

* [ML] Update MLLink to include globalState

* [ML] Update useTimeSeriesExplorerHref

* [ML] Update apm and security_solution to use useMlHref hook

* [ML] Update APM to use useUrlParams hook, update security solution hook

* [ML] Update tests, fix duplicate imports

* [ML] Update imports, remove ml exports to shared cause it's not needed

[ML] Add import

* [ML] Update snapshot

* [ML] Fix warnings for jobs_table.test.tsx

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/public/utils/testHelpers.tsx
@qn895 qn895 added the backport This PR is a backport of another PR label Oct 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
ml 1221 1222 +1

async chunks size

id before after diff
apm 4.2MB 4.2MB +935.0B
infra 3.8MB 3.8MB +8.0B
ml 10.6MB 10.6MB -16.7KB
securitySolution 10.3MB 10.3MB +801.0B
total -15.0KB

page load bundle size

id before after diff
apm 44.1KB 44.3KB +229.0B
ml 40.3KB 58.5KB +18.3KB
securitySolution 586.4KB 586.7KB +229.0B
total +18.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 marked this pull request as ready for review October 5, 2020 17:07
@qn895 qn895 merged commit 2876807 into elastic:7.x Oct 5, 2020
@qn895 qn895 deleted the backport/7.x/pr-78209 branch October 5, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants