Skip to content

[ML] DF Analytics creation: ensure job did not fail to start before showing results link #78200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2020
Merged

[ML] DF Analytics creation: ensure job did not fail to start before showing results link #78200

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aacfd6
ensure job did not fail to start before showing results link
alvarezmelissa87 Sep 22, 2020
c70e57b
simplify job started check
alvarezmelissa87 Sep 23, 2020
db42515
update job finished check
alvarezmelissa87 Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...e_analytics/pages/analytics_creation/components/create_step_footer/create_step_footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,11 @@ export const CreateStepFooter: FC<Props> = ({ jobId, jobType, showProgress }) =>
jobStats.state === DATA_FRAME_TASK_STATE.STOPPED
) {
clearInterval(interval);
setJobFinished(true);
// Check job has started. Jobs that fail to start will also have STOPPED state
setJobFinished(
progressStats.currentPhase === progressStats.totalPhases &&
progressStats.progress === 100
);
}
} else {
clearInterval(interval);
Expand Down