[Loggers] Rename "telemetry" to "usage" #78130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Feature:Telemetry
Feature:Home
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
YulNaumenko
approved these changes
Sep 22, 2020
Contributor
YulNaumenko
left a comment
YulNaumenko
left a comment
There was a problem hiding this comment.
Alerting changes LGTM
Member
Author
|
@elasticmachine merge upstream |
…/telemetry-loggers
Member
Author
|
@elasticmachine merge upstream |
…/telemetry-loggers
Member
Author
|
@elasticmachine merge upstream |
…/telemetry-loggers
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Oct 1, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
KibanaApp owned code LGTM, didn't test
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Elastic Machine <[email protected]>
afharo
deleted the
telemetry/rename-in-other-plugins-to-usage/telemetry-loggers
branch
afharo
added a commit
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 1, 2020
* master: (36 commits) [I18n] fix eui tokens (elastic#78951) Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768) Make the actual Vislib import async (elastic#78949) Fix ML conditionals links Cypress tests (elastic#78568) [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761) [UX] Improve page-load axis (elastic#78392) [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610) Data plugin README (elastic#78750) [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009) fixing api test (elastic#78964) [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129) [Loggers] Rename "telemetry" to "usage" (elastic#78130) [Usage Collection] [schema] `ui_metric` (elastic#78827) [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772) [Discover] Unskip doc link functional test (elastic#78600) [ML] Functional tests - stabilize calendar edit tests (elastic#78950) [UX] Improve page responsive (elastic#78759) [QA][Code Coverage] Team Assignment Docs Update (elastic#78890) [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (elastic#78209) [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855) ...
lukeelmers
added
Team:Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
telemetrytousageto avoid confusion in support and users.We've had a few open requests asking why they could see entries in the logs referring to "telemetry" when they explicitly set
telemetry.enabled: falseortelemetry.optIn: false.To avoid annoying users, let's use an alternative name when naming the loggers used for usage collection.
For maintainers