[Enterprise Search] Rename "telemetry" to "stats" #78124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Feature:Telemetry
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/app-search-frontend (Team:AppSearch) |
Contributor
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
scottybollinger
approved these changes
Sep 22, 2020
Contributor
scottybollinger
left a comment
scottybollinger
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this 🎉
afharo
deleted the
telemetry/rename-in-other-plugins-to-usage/enterprise_search
branch
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Sep 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (45 commits) [CSM] Use stacked chart for page views (elastic#78042) [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091) Remove service map beta badge (elastic#78039) [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124) [Alerting] optimize calculation of unmuted alert instances (elastic#78021) call .destroy on ace when react component unmounts (elastic#78132) [Ingest Manager] Fix agent action acknowledgement (elastic#78089) [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127) [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606) Bump backport to 5.6.0 (elastic#78097) [Actions] adds a Test Connector tab in the Connectors list (elastic#77365) [Uptime] Improve ping chart axis (elastic#77992) [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363) [UiActions] Remove duplicate apply filter action (elastic#77485) [APM] Use transaction metrics for transaction error rate (elastic#78009) [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983) Edit UI text strings in Integrations and Fleet tabs (elastic#75837) [baseline capture] switch to large workers (elastic#78109) [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956) [Mappings editor] Add support for point field type (elastic#77543) ...
Contributor
|
Thanks Alejandro!! Great call on the naming! 🎉 |
afharo
added a commit
that referenced
this pull request
Sep 22, 2020
lukeelmers
added
the
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
telemetrytostatsto avoid confusion in support and users.We've had a few open requests asking why they could see requests to endpoints named after "telemetry" when they explicitly set
telemetry.enabled: falseortelemetry.optIn: false.To avoid annoying users, let's use an alternative name when naming related plugins-owned endpoints.
Checklist
Delete any items that are not applicable to this PR.
For maintainers